cleanup

dagster-io · Jan 2, 2024 · a908bd2 · a908bd2
1 parent e8dd910
commit a908bd2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/python_modules/dagster/dagster/_core/execution/context/output.py b/python_modules/dagster/dagster/_core/execution/context/output.py
@@ -242,11 +242,6 @@ def op_def(self) -> "OpDefinition":
 
         return cast(OpDefinition, self._op_def)
 
-    @public
-    @property
-    def has_dagster_type(self) -> bool:
-        return self._dagster_type is not None
-
     @public
     @property
     def dagster_type(self) -> "DagsterType":

diff --git a/python_modules/dagster/dagster/_core/execution/plan/execute_step.py b/python_modules/dagster/dagster/_core/execution/plan/execute_step.py
@@ -717,7 +717,7 @@ def _store_output(
     if (
         step_output.properties.asset_check_key
         or (step_context.output_observes_source_asset(step_output_handle.output_name))
-        or output_context.dagster_type.is_nothing  # TODO - maybe need to scope this to just assets
+        or output_context.dagster_type.is_nothing
     ):
         yield from _log_asset_materialization_events_for_asset(
             step_context=step_context,