refactor(dbt): rename test_dagster_metadata to `test_dagster_meta_c…

…onfig` (#19546) ## Summary & Motivation Clarify that this project is testing dbt `+meta` config, rather than metadata emission. We'll use the old name for this project to actually test metadata emission. ## How I Tested These Changes bk
dagster-io · Feb 12, 2024 · afceff5 · afceff5
1 parent c2222ce
commit afceff5
Show file tree

Hide file tree

Showing 21 changed files with 24 additions and 20 deletions.
diff --git a/python_modules/libraries/dagster-dbt/dagster_dbt_tests/cli/test_app.py b/python_modules/libraries/dagster-dbt/dagster_dbt_tests/cli/test_app.py
@@ -15,7 +15,7 @@
 
 
 test_dagster_metadata_dbt_project_path = (
-    Path(__file__).joinpath("..", "..", "dbt_projects", "test_dagster_metadata").resolve()
+    Path(__file__).joinpath("..", "..", "dbt_projects", "test_dagster_meta_config").resolve()
 )
 
 runner = CliRunner()

diff --git a/...projects/test_dagster_metadata/.gitignore → ...jects/test_dagster_meta_config/.gitignore b/...projects/test_dagster_metadata/.gitignore → ...jects/test_dagster_meta_config/.gitignore
diff --git a/...cts/test_dagster_metadata/dbt_project.yml → .../test_dagster_meta_config/dbt_project.yml b/...cts/test_dagster_metadata/dbt_project.yml → .../test_dagster_meta_config/dbt_project.yml
@@ -1,4 +1,4 @@
-name: "test_dagster_metadata"
+name: "test_dagster_meta_config"
 
 config-version: 2
 version: "0.1"
@@ -24,7 +24,7 @@ seeds:
     node_color: "#cd7f32"
 
 models:
-  test_dagster_metadata:
+  test_dagster_meta_config:
     materialized: table
     staging:
       materialized: view

diff --git a/...braries/dagster-dbt/dagster_dbt_tests/dbt_projects/test_dagster_meta_config/manifest.json b/...braries/dagster-dbt/dagster_dbt_tests/dbt_projects/test_dagster_meta_config/manifest.json
diff --git a/...est_dagster_metadata/models/customers.sql → ..._dagster_meta_config/models/customers.sql b/...est_dagster_metadata/models/customers.sql → ..._dagster_meta_config/models/customers.sql
diff --git a/...ects/test_dagster_metadata/models/docs.md → ...s/test_dagster_meta_config/models/docs.md b/...ects/test_dagster_metadata/models/docs.md → ...s/test_dagster_meta_config/models/docs.md
diff --git a/...s/test_dagster_metadata/models/orders.sql → ...est_dagster_meta_config/models/orders.sql b/...s/test_dagster_metadata/models/orders.sql → ...est_dagster_meta_config/models/orders.sql
diff --git a/.../test_dagster_metadata/models/overview.md → ...st_dagster_meta_config/models/overview.md b/.../test_dagster_metadata/models/overview.md → ...st_dagster_meta_config/models/overview.md
diff --git a/...s/test_dagster_metadata/models/schema.yml → ...est_dagster_meta_config/models/schema.yml b/...s/test_dagster_metadata/models/schema.yml → ...est_dagster_meta_config/models/schema.yml
diff --git a/...agster_metadata/models/staging/schema.yml → ...ter_meta_config/models/staging/schema.yml b/...agster_metadata/models/staging/schema.yml → ...ter_meta_config/models/staging/schema.yml
diff --git a/...metadata/models/staging/stg_customers.sql → ...a_config/models/staging/stg_customers.sql b/...metadata/models/staging/stg_customers.sql → ...a_config/models/staging/stg_customers.sql
diff --git a/...er_metadata/models/staging/stg_orders.sql → ...meta_config/models/staging/stg_orders.sql b/...er_metadata/models/staging/stg_orders.sql → ...meta_config/models/staging/stg_orders.sql
diff --git a/..._metadata/models/staging/stg_payments.sql → ...ta_config/models/staging/stg_payments.sql b/..._metadata/models/staging/stg_payments.sql → ...ta_config/models/staging/stg_payments.sql
diff --git a/...ojects/test_dagster_metadata/profiles.yml → ...cts/test_dagster_meta_config/profiles.yml b/...ojects/test_dagster_metadata/profiles.yml → ...cts/test_dagster_meta_config/profiles.yml
diff --git a/...ects/test_dagster_metadata/seeds/.gitkeep → ...s/test_dagster_meta_config/seeds/.gitkeep b/...ects/test_dagster_metadata/seeds/.gitkeep → ...s/test_dagster_meta_config/seeds/.gitkeep
diff --git a/..._dagster_metadata/seeds/raw_customers.csv → ...gster_meta_config/seeds/raw_customers.csv b/..._dagster_metadata/seeds/raw_customers.csv → ...gster_meta_config/seeds/raw_customers.csv
diff --git a/...est_dagster_metadata/seeds/raw_orders.csv → ..._dagster_meta_config/seeds/raw_orders.csv b/...est_dagster_metadata/seeds/raw_orders.csv → ..._dagster_meta_config/seeds/raw_orders.csv
diff --git a/...t_dagster_metadata/seeds/raw_payments.csv → ...agster_meta_config/seeds/raw_payments.csv b/...t_dagster_metadata/seeds/raw_payments.csv → ...agster_meta_config/seeds/raw_payments.csv
diff --git a/.../libraries/dagster-dbt/dagster_dbt_tests/dbt_projects/test_dagster_metadata/manifest.json b/.../libraries/dagster-dbt/dagster_dbt_tests/dbt_projects/test_dagster_metadata/manifest.json
diff --git a/python_modules/libraries/dagster-dbt/dagster_dbt_tests/test_asset_decorator.py b/python_modules/libraries/dagster-dbt/dagster_dbt_tests/test_asset_decorator.py
@@ -32,12 +32,12 @@
 manifest_path = Path(__file__).joinpath("..", "sample_manifest.json").resolve()
 manifest = json.loads(manifest_path.read_bytes())
 
-test_dagster_metadata_manifest_path = (
+test_dagster_meta_config_manifest_path = (
     Path(__file__)
-    .joinpath("..", "dbt_projects", "test_dagster_metadata", "manifest.json")
+    .joinpath("..", "dbt_projects", "test_dagster_meta_config", "manifest.json")
     .resolve()
 )
-test_dagster_metadata_manifest = json.loads(test_dagster_metadata_manifest_path.read_bytes())
+test_dagster_meta_config_manifest = json.loads(test_dagster_meta_config_manifest_path.read_bytes())
 
 test_dagster_asset_key_exceptions_path = (
     Path(__file__)
@@ -424,7 +424,7 @@ def get_partition_mapping(
             return partition_mapping
 
     @dbt_assets(
-        manifest=test_dagster_metadata_manifest,
+        manifest=test_dagster_meta_config_manifest,
         dagster_dbt_translator=CustomizedDagsterDbtTranslator(),
         partitions_def=DailyPartitionsDefinition(start_date="2023-10-01"),
     )
@@ -535,7 +535,7 @@ def my_dbt_assets():
 
 
 def test_dbt_meta_auto_materialize_policy() -> None:
-    @dbt_assets(manifest=test_dagster_metadata_manifest)
+    @dbt_assets(manifest=test_dagster_meta_config_manifest)
     def my_dbt_assets():
         ...
 
@@ -547,7 +547,7 @@ def my_dbt_assets():
 
 
 def test_dbt_meta_freshness_policy() -> None:
-    @dbt_assets(manifest=test_dagster_metadata_manifest)
+    @dbt_assets(manifest=test_dagster_meta_config_manifest)
     def my_dbt_assets():
         ...
 
@@ -561,7 +561,7 @@ def my_dbt_assets():
 
 
 def test_dbt_meta_asset_key() -> None:
-    @dbt_assets(manifest=test_dagster_metadata_manifest)
+    @dbt_assets(manifest=test_dagster_meta_config_manifest)
     def my_dbt_assets():
         ...
 
@@ -579,7 +579,7 @@ def my_dbt_assets():
 
 
 def test_dbt_config_group() -> None:
-    @dbt_assets(manifest=test_dagster_metadata_manifest)
+    @dbt_assets(manifest=test_dagster_meta_config_manifest)
     def my_dbt_assets():
         ...
 
@@ -599,7 +599,7 @@ def my_dbt_assets():
 
 
 def test_dbt_with_downstream_asset_via_definition():
-    @dbt_assets(manifest=test_dagster_metadata_manifest)
+    @dbt_assets(manifest=test_dagster_meta_config_manifest)
     def my_dbt_assets():
         ...
 
@@ -613,7 +613,7 @@ def downstream_of_dbt():
 
 
 def test_dbt_with_downstream_asset():
-    @dbt_assets(manifest=test_dagster_metadata_manifest)
+    @dbt_assets(manifest=test_dagster_meta_config_manifest)
     def my_dbt_assets():
         ...
 
@@ -629,7 +629,9 @@ def downstream_of_dbt():
 def test_dbt_with_custom_resource_key() -> None:
     dbt_resource_key = "my_custom_dbt_resource_key"
 
-    @dbt_assets(manifest=test_dagster_metadata_manifest, required_resource_keys={dbt_resource_key})
+    @dbt_assets(
+        manifest=test_dagster_meta_config_manifest, required_resource_keys={dbt_resource_key}
+    )
     def my_dbt_assets(context: AssetExecutionContext):
         dbt = getattr(context.resources, dbt_resource_key)
 
@@ -639,7 +641,9 @@ def my_dbt_assets(context: AssetExecutionContext):
         [my_dbt_assets],
         resources={
             dbt_resource_key: DbtCliResource(
-                project_dir=os.fspath(test_dagster_metadata_manifest_path.joinpath("..").resolve())
+                project_dir=os.fspath(
+                    test_dagster_meta_config_manifest_path.joinpath("..").resolve()
+                )
             )
         },
     )
@@ -756,8 +760,8 @@ def get_asset_key(cls, dbt_resource_props: Mapping[str, Any]) -> AssetKey:
     expected_error_message = "\n".join(
         [
             "The following dbt resources have the asset key `['duplicate']`:",
-            "  - `model.test_dagster_metadata.customers` (models/customers.sql)",
-            "  - `model.test_dagster_metadata.orders` (models/orders.sql)",
+            "  - `model.test_dagster_meta_config.customers` (models/customers.sql)",
+            "  - `model.test_dagster_meta_config.orders` (models/orders.sql)",
         ]
     )
 
@@ -767,7 +771,7 @@ def get_asset_key(cls, dbt_resource_props: Mapping[str, Any]) -> AssetKey:
     ) as exc_info:
 
         @dbt_assets(
-            manifest=test_dagster_metadata_manifest,
+            manifest=test_dagster_meta_config_manifest,
             dagster_dbt_translator=CustomDagsterDbtTranslator(),
         )
         def my_dbt_assets():

diff --git a/python_modules/libraries/dagster-dbt/dagster_dbt_tests/test_dependencies.py b/python_modules/libraries/dagster-dbt/dagster_dbt_tests/test_dependencies.py
@@ -8,7 +8,7 @@
 
 manifest_path = (
     Path(__file__)
-    .joinpath("..", "dbt_projects", "test_dagster_metadata", "manifest.json")
+    .joinpath("..", "dbt_projects", "test_dagster_meta_config", "manifest.json")
     .resolve()
 )
 manifest = json.loads(manifest_path.read_bytes())