Skip to content

Commit

Permalink
rename
Browse files Browse the repository at this point in the history
  • Loading branch information
benpankow committed May 9, 2024
1 parent f82332b commit baffd84
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class UrlCodeReference(DagsterModel):
in source control.
"""

source_control_url: str
url: str
label: Optional[str] = None


Expand Down Expand Up @@ -152,7 +152,7 @@ def convert_local_path_to_source_control_path(
)

return UrlCodeReference(
source_control_url=f"{base_source_control_url}/{source_file_from_repo_root}#L{local_path.line_number}",
url=f"{base_source_control_url}/{source_file_from_repo_root}#L{local_path.line_number}",
label=local_path.label,
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def test_asset_code_origins_source_control() -> None:
asset.metadata_by_key[key]["dagster/code_references"].code_references[-1],
)

assert meta.source_control_url == (
assert meta.url == (
"https://github.com/dagster-io/dagster/tree/master/python_modules/dagster"
+ (expected_file_path[len(DAGSTER_PACKAGE_PATH) :])
+ f"#L{expected_line_number}"
Expand Down

0 comments on commit baffd84

Please sign in to comment.