Skip to content

Commit

Permalink
[dagster-datahub] (loosen pydantic requirement) (#23393)
Browse files Browse the repository at this point in the history
## Summary & Motivation
This pydantic requirement is needlessly strict give that the usage of
Field is only in one file and uses only two parameters of it (both of
which have not changed since the Pydantic 2.0 upgrade). This needlessly
strict requirement is making it so that this won't resolve with other
packages that require pydantic 2.0. Can we please loosen this
restriction?

## How I Tested These Changes
Used the forked repo via pip

---------

Co-authored-by: Colton Padden <[email protected]>
  • Loading branch information
kevin-longe-unmind and cmpadden authored Aug 9, 2024
1 parent 61b6a75 commit be2db95
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ class DatahubConnection(Config):

class DatahubKafkaEmitterResource(ConfigurableResource):
connection: DatahubConnection
topic: Optional[str] = None
topic_routes: Dict[str, str] = Field(
default={
MCE_KEY: DEFAULT_MCE_KAFKA_TOPIC,
Expand Down
2 changes: 1 addition & 1 deletion python_modules/libraries/dagster-datahub/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def get_version() -> str:
f"dagster{pin}",
"packaging",
"requests",
"pydantic>=1.10.0,<2.0.0",
"pydantic>=1.10.0,<3.0.0",
],
extras_require={},
zip_safe=False,
Expand Down

0 comments on commit be2db95

Please sign in to comment.