Add groups to build_airbyte_assets (#14315)

## Summary & Motivation [A request from slack](https://dagster.slack.com/archives/C047VPGQUTV/p1684233197624719) to include a way to add a group to airbyte assets made with the `build_airbyte_assets` function. It seemed pretty straight forward so I picked it up for my first PR. ## How I Tested These Changes Extended the tests to check that the created assets have the correct group --------- Co-authored-by: benpankow <[email protected]>
dagster-io · Jun 23, 2023 · c0392b3 · c0392b3 · github-actions · Jun 23, 2023
1 parent b7b4a4e
commit c0392b3
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 3 deletions.
diff --git a/docs/content/api/modules.json b/docs/content/api/modules.json
diff --git a/docs/content/api/searchindex.json b/docs/content/api/searchindex.json
diff --git a/docs/content/api/sections.json b/docs/content/api/sections.json
diff --git a/docs/next/public/objects.inv b/docs/next/public/objects.inv
diff --git a/python_modules/libraries/dagster-airbyte/dagster_airbyte/asset_defs.py b/python_modules/libraries/dagster-airbyte/dagster_airbyte/asset_defs.py
@@ -206,6 +206,7 @@ def build_airbyte_assets(
     connection_id: str,
     destination_tables: Sequence[str],
     asset_key_prefix: Optional[Sequence[str]] = None,
+    group_name: Optional[str] = None,
     normalization_tables: Optional[Mapping[str, Set[str]]] = None,
     upstream_assets: Optional[Set[AssetKey]] = None,
     schema_by_table_name: Optional[Mapping[str, TableSchema]] = None,
@@ -264,6 +265,7 @@ def build_airbyte_assets(
         outs=outputs,
         internal_asset_deps=internal_deps,
         compute_kind="airbyte",
+        group_name=group_name,
     )
     def _assets(context, airbyte: BaseAirbyteResource):
         ab_output = airbyte.sync_and_poll(connection_id=connection_id)

diff --git a/python_modules/libraries/dagster-airbyte/dagster_airbyte_tests/test_asset_defs.py b/python_modules/libraries/dagster-airbyte/dagster_airbyte_tests/test_asset_defs.py
@@ -202,6 +202,7 @@ def test_assets_cloud() -> None:
         destination_tables=["foo", "bar"],
         normalization_tables={"bar": {"bar_baz", "bar_qux"}},
         asset_key_prefix=["some", "prefix"],
+        group_name="foo",
     )
 
     ab_job = build_assets_job(
@@ -243,3 +244,9 @@ def test_assets_cloud() -> None:
             AssetKey(["some", "prefix", "bar_baz"]),
             AssetKey(["some", "prefix", "bar_qux"]),
         }
+        assert ab_assets[0].group_names_by_key == {
+            AssetKey(["some", "prefix", "foo"]): "foo",
+            AssetKey(["some", "prefix", "bar"]): "foo",
+            AssetKey(["some", "prefix", "bar_baz"]): "foo",
+            AssetKey(["some", "prefix", "bar_qux"]): "foo",
+        }