fix test a different way to preserve old behavior

dagster-io · Apr 25, 2024 · c39367f · c39367f
1 parent 14cfd1c
commit c39367f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/app/__tests__/analytics.test.tsx b/js_modules/dagster-ui/packages/ui-core/src/app/__tests__/analytics.test.tsx
@@ -58,7 +58,6 @@ describe('Analytics', () => {
 
   describe('Event tracking', () => {
     const Page = () => {
-      useTrackPageView();
       const trackEvent = useTrackEvent();
       const onClick = () => {
         trackEvent('thingClick');

diff --git a/js_modules/dagster-ui/packages/ui-core/src/app/analytics.tsx b/js_modules/dagster-ui/packages/ui-core/src/app/analytics.tsx
@@ -76,12 +76,14 @@ export const useTrackPageView = () => {
 
 export const useTrackEvent = () => {
   const analytics = useAnalytics();
-  const pathValues = usePageContext();
+  const match = useRouteMatch();
+  const {pathname: specificPath} = useLocation();
+  const {path} = match;
 
   return useCallback(
     (eventName: string, properties?: Record<string, any>) => {
-      analytics.track(eventName, {...properties, ...pathValues});
+      analytics.track(eventName, {...properties, path, specificPath});
     },
-    [analytics, pathValues],
+    [analytics, path, specificPath],
   );
 };