Skip to content

Commit

Permalink
comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jamiedemaria committed Dec 23, 2024
1 parent 997a5eb commit cbaa1ab
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,12 @@ export const AutomaterializeMiddlePanelWithData = ({

const {partitions: allPartitions} = usePartitionsForAssetKey(definition?.assetKey.path || []);

// DA will either request a list of runs or a single backfill. When DA requests a backfill
// we want to show a row for that backfill in the table, so we need to construct the RunsFilter
// differently. Backfill IDs are 8 characters long, so we can use that to determine if a
// backfill was requested. If DA is updated to request multiple backfills in a single evaluation,
// or emit a combination of runs and backfills in a single evaluation, this logic will need to
// be updated.
// For a single asset for a single tick, DA will either request a list of runs or a single backfill.
// When DA requests a backfill we want to show a row for that backfill in the table, so we need to
// construct the RunsFilter differently. Backfill IDs are 8 characters long, so we can use that to
// determine if a backfill was requested. If DA is updated to request multiple backfills in a
// single evaluation, or emit a combination of runs and backfills in a single evaluation, this
// logic will need to be updated.
const backfillIdLength = 8;
const runsFilter: RunsFilter | null = useMemo(
() =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,9 @@ def build_run_requests(
run_tags: Optional[Mapping[str, str]],
emit_backfills: bool,
) -> Sequence[RunRequest]:
"""For a single asset in a given tick, the asset will only be part of a run or a backfill, not both.
If the asset is targetd by a backfill, there will only be one backfill that targets the asset.
"""
if emit_backfills:
backfill_run_request, entity_subsets = _build_backfill_request(
entity_subsets, asset_graph, run_tags
Expand Down

0 comments on commit cbaa1ab

Please sign in to comment.