-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add DagsterCodeLocationLoadError to the set of errors that the schedu…
…ler will retry mid-tick (#17224) Summary: If the code server becomes unreachable in the middle of the tick due to a reload, it can cause this codepath to raise a DagsterCodeLocationLoadError https://github.com/dagster-io/dagster/blob/master/python_modules/dagster/dagster/_scheduler/scheduler.py#L720 We should treat that similar to a DagsterUserCodeUnreachableError (which is the more common way the code server going down will manifest in the scheduler) and pause the schedule tick until it's available again. This mirrors the list of errors that we retry in the run deqeuer daemon as 'user code failures': https://github.com/dagster-io/dagster/blob/master/python_modules/dagster/dagster/_daemon/run_coordinator/queued_run_coordinator_daemon.py#L345-L347 Test Plan: BK, new test case ## Summary & Motivation ## How I Tested These Changes
- Loading branch information
Showing
2 changed files
with
60 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters