Option to execute individual asset checks when launching runs via Lau…

…nchpad

js_modules/dagster-ui/packages/ui-core/src/app/ExecutionSessionStorage.tsx

@@ -1,7 +1,7 @@
 import memoize from 'lodash/memoize';
 import * as React from 'react';
 
-import {AssetKeyInput} from '../graphql/types';
+import {AssetKeyInput, AssetCheck} from '../graphql/types';
 import {useSetStateUpdateCallback} from '../hooks/useSetStateUpdateCallback';
 import {getJSONForKey, useStateWithStorage} from '../hooks/useStateWithStorage';
 import {
@@ -43,6 +43,8 @@ export interface IExecutionSession {
   mode: string | null;
   needsRefresh: boolean;
   assetSelection: {assetKey: AssetKeyInput; opNames: string[]}[] | null;
+  assetChecksAvailable: Pick<AssetCheck, 'name' | 'canExecuteIndividually' | 'assetKey'>[];
+  includeSeparatelyExecutableChecks: boolean;
   solidSelection: string[] | null;
   solidSelectionQuery: string | null;
   flattenGraphs: boolean;
@@ -95,6 +97,8 @@ export const createSingleSession = (initial: IExecutionSessionChanges = {}, key?
     base: null,
     needsRefresh: false,
     assetSelection: null,
+    assetChecksAvailable: [],
+    includeSeparatelyExecutableChecks: true,
     solidSelection: null,
     solidSelectionQuery: '*',
     flattenGraphs: false,

js_modules/dagster-ui/packages/ui-core/src/app/__tests__/ExecutionSessionStorage.test.tsx

@@ -223,6 +223,8 @@ describe('ExecutionSessionStorage', () => {
               mode: 'default',
               needsRefresh: false,
               assetSelection: null,
+              assetChecksAvailable: [],
+              includeSeparatelyExecutableChecks: true,
               solidSelection: null,
               solidSelectionQuery: '*',
               flattenGraphs: false,
@@ -271,6 +273,8 @@ describe('ExecutionSessionStorage', () => {
               mode: 'default',
               needsRefresh: false,
               assetSelection: null,
+              assetChecksAvailable: [],
+              includeSeparatelyExecutableChecks: true,
               solidSelection: null,
               solidSelectionQuery: '*',
               flattenGraphs: false,

js_modules/dagster-ui/packages/ui-core/src/assets/AssetWipeDialog.tsx

@@ -5,6 +5,7 @@ import * as React from 'react';
 import {PYTHON_ERROR_FRAGMENT} from '../app/PythonErrorFragment';
 import {displayNameForAssetKey} from '../asset-graph/Utils';
 
+import {asAssetKeyInput} from './asInput';
 import {AssetWipeMutation, AssetWipeMutationVariables} from './types/AssetWipeDialog.types';
 
 interface AssetKey {
@@ -21,7 +22,7 @@ export const AssetWipeDialog: React.FC<{
   const [requestWipe] = useMutation<AssetWipeMutation, AssetWipeMutationVariables>(
     ASSET_WIPE_MUTATION,
     {
-      variables: {assetKeys: assetKeys.map((key) => ({path: key.path || []}))},
+      variables: {assetKeys: assetKeys.map(asAssetKeyInput)},
       refetchQueries: requery,
     },
   );

js_modules/dagster-ui/packages/ui-core/src/assets/LaunchAssetChoosePartitionsDialog.tsx

@@ -31,7 +31,7 @@ import {
   itemWithAssetKey,
 } from '../asset-graph/Utils';
 import {AssetKey} from '../assets/types';
-import {LaunchBackfillParams, PartitionDefinitionType} from '../graphql/types';
+import {AssetCheck, LaunchBackfillParams, PartitionDefinitionType} from '../graphql/types';
 import {LAUNCH_PARTITION_BACKFILL_MUTATION} from '../instance/backfill/BackfillUtils';
 import {
   LaunchPartitionBackfillMutation,
@@ -72,6 +72,7 @@ import {
 } from './MultipartitioningSupport';
 import {PartitionHealthSummary} from './PartitionHealthSummary';
 import {RunningBackfillsNotice} from './RunningBackfillsNotice';
+import {asAssetKeyInput} from './asInput';
 import {
   LaunchAssetWarningsQuery,
   LaunchAssetWarningsQueryVariables,
@@ -93,6 +94,7 @@ interface Props {
   target: LaunchAssetsChoosePartitionsTarget;
   assets: {
     assetKey: AssetKey;
+    assetChecks: Pick<AssetCheck, 'name'>[];
     opNames: string[];
     partitionDefinition: PartitionDefinitionForLaunchAssetFragment | null;
   }[];
@@ -348,7 +350,7 @@ const LaunchAssetChoosePartitionsDialogBody: React.FC<Props> = ({
       target.type === 'job' && !isHiddenAssetGroupJob(target.jobName)
         ? {
             tags,
-            assetSelection: assets.map((a) => ({path: a.assetKey.path})),
+            assetSelection: assets.map(asAssetKeyInput),
             partitionNames: keysFiltered,
             fromFailure: false,
             selector: {
@@ -362,12 +364,12 @@ const LaunchAssetChoosePartitionsDialogBody: React.FC<Props> = ({
         : target.type === 'pureAll'
         ? {
             tags,
-            assetSelection: assets.map((a) => ({path: a.assetKey.path})),
+            assetSelection: assets.map(asAssetKeyInput),
             allPartitions: true,
           }
         : {
             tags,
-            assetSelection: assets.map((a) => ({path: a.assetKey.path})),
+            assetSelection: assets.map(asAssetKeyInput),
             partitionNames: keysFiltered,
             fromFailure: false,
           };

js_modules/dagster-ui/packages/ui-core/src/assets/LaunchAssetExecutionButton.tsx

@@ -38,6 +38,7 @@ import {MULTIPLE_DEFINITIONS_WARNING} from './AssetDefinedInMultipleReposNotice'
 import {LaunchAssetChoosePartitionsDialog} from './LaunchAssetChoosePartitionsDialog';
 import {partitionDefinitionsEqual} from './MultipartitioningSupport';
 import {isAssetMissing, isAssetStale} from './Stale';
+import {asAssetKeyInput, getAssetCheckHandleInputs} from './asInput';
 import {AssetKey} from './types';
 import {
   LaunchAssetExecutionAssetNodeFragment,
@@ -289,7 +290,7 @@ export const useMaterializationAction = (preferredJobName?: string) => {
 
     const result = await client.query<LaunchAssetLoaderQuery, LaunchAssetLoaderQueryVariables>({
       query: LAUNCH_ASSET_LOADER_QUERY,
-      variables: {assetKeys: assetKeys.map(({path}) => ({path}))},
+      variables: {assetKeys: assetKeys.map(asAssetKeyInput)},
     });
 
     if (result.data.assetNodeDefinitionCollisions.length) {
@@ -373,7 +374,7 @@ export const useMaterializationAction = (preferredJobName?: string) => {
               LaunchAssetLoaderQueryVariables
             >({
               query: LAUNCH_ASSET_LOADER_QUERY,
-              variables: {assetKeys: state.assets.map(({assetKey}) => ({path: assetKey.path}))},
+              variables: {assetKeys: state.assets.map(asAssetKeyInput)},
             });
             const assets = result.data.assetNodes;
             const next = await stateForLaunchingAssets(client, assets, false, preferredJobName);
@@ -502,6 +503,10 @@ async function stateForLaunchingAssets(
       sessionPresets: {
         flattenGraphs: true,
         assetSelection: assets.map((a) => ({assetKey: a.assetKey, opNames: a.opNames})),
+        assetChecksAvailable: assets.flatMap((a) =>
+          a.assetChecks.map((check) => ({...check, assetKey: a.assetKey})),
+        ),
+        includeSeparatelyExecutableChecks: true,
         solidSelectionQuery: assetOpNames.map((name) => `"${name}"`).join(', '),
         base: partitionSetName
           ? {partitionsSetName: partitionSetName, partitionName: null, tags: []}
@@ -600,7 +605,7 @@ async function upstreamAssetsWithNoMaterializations(
 export function executionParamsForAssetJob(
   repoAddress: RepoAddress,
   jobName: string,
-  assets: {assetKey: AssetKey; opNames: string[]}[],
+  assets: {assetKey: AssetKey; opNames: string[]; assetChecks: {name: string}[]}[],
   tags: {key: string; value: string}[],
 ): LaunchPipelineExecutionMutationVariables['executionParams'] {
   return {
@@ -613,9 +618,8 @@ export function executionParamsForAssetJob(
       repositoryLocationName: repoAddress.location,
       repositoryName: repoAddress.name,
       pipelineName: jobName,
-      assetSelection: assets.map((asset) => ({
-        path: asset.assetKey.path,
-      })),
+      assetSelection: assets.map(asAssetKeyInput),
+      assetCheckSelection: getAssetCheckHandleInputs(assets),
     },
   };
 }
@@ -674,6 +678,10 @@ const LAUNCH_ASSET_EXECUTION_ASSET_NODE_FRAGMENT = gql`
     assetKey {
       path
     }
+    assetChecks {
+      name
+      canExecuteIndividually
+    }
     dependencyKeys {
       path
     }

js_modules/dagster-ui/packages/ui-core/src/assets/LaunchAssetObservationButton.tsx

@@ -15,6 +15,7 @@ import {
   getCommonJob,
   LAUNCH_ASSET_LOADER_QUERY,
 } from './LaunchAssetExecutionButton';
+import {asAssetKeyInput} from './asInput';
 import {
   LaunchAssetExecutionAssetNodeFragment,
   LaunchAssetLoaderQuery,
@@ -73,7 +74,7 @@ export const LaunchAssetObservationButton: React.FC<{
 
     const result = await client.query<LaunchAssetLoaderQuery, LaunchAssetLoaderQueryVariables>({
       query: LAUNCH_ASSET_LOADER_QUERY,
-      variables: {assetKeys: scopeAssets.map((a) => ({path: a.assetKey.path}))},
+      variables: {assetKeys: scopeAssets.map(asAssetKeyInput)},
     });
 
     if (result.data.assetNodeDefinitionCollisions.length) {

js_modules/dagster-ui/packages/ui-core/src/assets/asInput.ts

@@ -0,0 +1,24 @@
+import {AssetCheckHandleInput} from '../graphql/types';
+
+import {AssetKey} from './types';
+
+export function getAssetCheckHandleInputs(
+  assets: {assetKey: AssetKey; assetChecks: {name: string}[]}[],
+): AssetCheckHandleInput[] {
+  return assets.flatMap((a) =>
+    a.assetChecks.map((check) => ({name: check.name, assetKey: {path: a.assetKey.path}})),
+  );
+}
+
+// The `.map` calls below sanitize the __typename and other possible fields out of the
+// assetSelection / assetCheckSelection because GraphQL is strict about extra values.
+
+export function asAssetKeyInput(assetOrAssetKey: {assetKey: {path: string[]}} | {path: string[]}) {
+  return 'path' in assetOrAssetKey
+    ? {path: assetOrAssetKey.path}
+    : {path: assetOrAssetKey.assetKey.path};
+}
+
+export function asAssetCheckHandleInput(check: {name: string; assetKey: {path: string[]}}) {
+  return {name: check.name, assetKey: {path: check.assetKey.path}};
+}

js_modules/dagster-ui/packages/ui-core/src/assets/asset-checks/ExecuteChecksButton.tsx

@@ -3,7 +3,7 @@ import {Button, Icon, Spinner, Tooltip} from '@dagster-io/ui-components';
 import React, {useState} from 'react';
 
 import {usePermissionsForLocation} from '../../app/Permissions';
-import {AssetCheckCanExecuteIndividually} from '../../graphql/types';
+import {AssetCheckCanExecuteIndividually, ExecutionParams} from '../../graphql/types';
 import {useLaunchPadHooks} from '../../launchpad/LaunchpadHooksContext';
 
 import {
@@ -68,24 +68,23 @@ export const ExecuteChecksButton = ({
   }
 
   const onClick = async () => {
-    const params = {
-      executionParams: {
-        mode: 'default',
-        executionMetadata: {},
-        runConfigData: '{}',
-        selector: {
-          repositoryLocationName: repository.location.name,
-          repositoryName: repository.name,
-          jobName,
-          assetCheckSelection: launchable.map((c) => ({
-            assetKey: {path: assetKey.path},
-            name: c.name,
-          })),
-        },
+    const executionParams: ExecutionParams = {
+      mode: 'default',
+      executionMetadata: {},
+      runConfigData: '{}',
+      selector: {
+        jobName,
+        repositoryLocationName: repository.location.name,
+        repositoryName: repository.name,
+        assetSelection: [],
+        assetCheckSelection: launchable.map((c) => ({
+          assetKey: {path: assetKey.path},
+          name: c.name,
+        })),
       },
     };
     setLaunching(true);
-    await launchWithTelemetry(params, 'toast');
+    await launchWithTelemetry({executionParams}, 'toast');
     setLaunching(false);
   };