Skip to content

Commit

Permalink
[ui] Upgrade Storybook (#23445)
Browse files Browse the repository at this point in the history
## Summary & Motivation

I just realized that my change to upgrade `elliptic` won't resolve the
dependabot alerts. I misread the alert -- there is currently no version
of `elliptic` that resolves the issue, so I was just upgrading us to the
latest (still broken) version.

Our `elliptic` usage is part of the dependencies of Storybook, so I
figured maybe the latest Storybook version would have eliminated it. No
such luck, but here's the Storybook upgrade anyway.

## How I Tested These Changes

`yarn storybook` in `ui-core` and `ui-components`.
  • Loading branch information
hellendag authored Aug 6, 2024
1 parent 204f143 commit dafc5a6
Show file tree
Hide file tree
Showing 5 changed files with 548 additions and 2,525 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ const config = {
getAbsolutePath('@storybook/addon-themes'),
getAbsolutePath('@storybook/addon-links'),
getAbsolutePath('@storybook/addon-essentials'),
getAbsolutePath('@storybook/addon-mdx-gfm'),
'@chromatic-com/storybook',
getAbsolutePath('@chromatic-com/storybook'),
],
framework: {
name: getAbsolutePath('@storybook/nextjs'),
Expand Down
21 changes: 10 additions & 11 deletions js_modules/dagster-ui/packages/ui-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"@babel/preset-env": "^7.16.7",
"@babel/preset-react": "^7.16.7",
"@babel/preset-typescript": "^7.16.7",
"@chromatic-com/storybook": "^1",
"@chromatic-com/storybook": "^1.6.1",
"@dagster-io/eslint-config": "1.0.15",
"@mdx-js/react": "^1.6.22",
"@rollup/plugin-babel": "^5.3.1",
Expand All @@ -56,15 +56,14 @@
"@rollup/plugin-node-resolve": "^13.1.3",
"@rollup/plugin-replace": "^4.0.0",
"@rollup/plugin-url": "^6.1.0",
"@storybook/addon-actions": "^8.1.10",
"@storybook/addon-docs": "^8.1.10",
"@storybook/addon-essentials": "^8.1.10",
"@storybook/addon-links": "^8.1.10",
"@storybook/addon-mdx-gfm": "^8.1.10",
"@storybook/addon-themes": "^8.1.10",
"@storybook/icons": "^1.2.9",
"@storybook/nextjs": "^8.1.10",
"@storybook/react": "^8.1.10",
"@storybook/addon-actions": "^8.2.7",
"@storybook/addon-docs": "^8.2.7",
"@storybook/addon-essentials": "^8.2.7",
"@storybook/addon-links": "^8.2.7",
"@storybook/addon-themes": "^8.2.7",
"@storybook/icons": "^1.2.10",
"@storybook/nextjs": "^8.2.7",
"@storybook/react": "^8.2.7",
"@testing-library/dom": "^10.0.0",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^16.0.0",
Expand Down Expand Up @@ -98,7 +97,7 @@
"rollup-plugin-node-globals": "^1.4.0",
"rollup-plugin-polyfill-node": "^0.8.0",
"rollup-plugin-styles": "^4.0.0",
"storybook": "^8.1.10",
"storybook": "^8.2.7",
"typescript": "5.4.5",
"webpack": "^5.88.1"
},
Expand Down
3 changes: 1 addition & 2 deletions js_modules/dagster-ui/packages/ui-core/.storybook/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ const config = {
getAbsolutePath('@storybook/addon-themes'),
getAbsolutePath('@storybook/addon-links'),
getAbsolutePath('@storybook/addon-essentials'),
getAbsolutePath('@storybook/addon-mdx-gfm'),
'@chromatic-com/storybook',
getAbsolutePath('@chromatic-com/storybook'),
],
typescript: {
reactDocgen: false,
Expand Down
19 changes: 9 additions & 10 deletions js_modules/dagster-ui/packages/ui-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"@babel/runtime": "^7.13.10",
"@blueprintjs/popover2": "1.13.12",
"@blueprintjs/select": "^4.9.12",
"@chromatic-com/storybook": "^1",
"@chromatic-com/storybook": "^1.6.1",
"@dagster-io/eslint-config": "workspace:*",
"@dagster-io/ui-components": "workspace:*",
"@graphql-codegen/add": "^5.0.2",
Expand All @@ -98,14 +98,13 @@
"@graphql-tools/mock": "^8.5.0",
"@graphql-tools/schema": "^8.3.1",
"@mdx-js/react": "^1.6.22",
"@storybook/addon-actions": "^8.1.10",
"@storybook/addon-docs": "^8.1.10",
"@storybook/addon-essentials": "^8.1.10",
"@storybook/addon-links": "^8.1.10",
"@storybook/addon-mdx-gfm": "^8.1.10",
"@storybook/addon-themes": "^8.1.10",
"@storybook/nextjs": "^8.1.10",
"@storybook/react": "^8.1.10",
"@storybook/addon-actions": "^8.2.7",
"@storybook/addon-docs": "^8.2.7",
"@storybook/addon-essentials": "^8.2.7",
"@storybook/addon-links": "^8.2.7",
"@storybook/addon-themes": "^8.2.7",
"@storybook/nextjs": "^8.2.7",
"@storybook/react": "^8.2.7",
"@testing-library/dom": "^10.0.0",
"@testing-library/jest-dom": "^6.4.2",
"@testing-library/react": "^16.0.0",
Expand Down Expand Up @@ -153,7 +152,7 @@
"react-router-dom": "^5.3.0",
"react-router-dom-v5-compat": "^6.3.0",
"resize-observer-polyfill": "^1.5.1",
"storybook": "^8.1.10",
"storybook": "^8.2.7",
"styled-components": "^5.3.3",
"ts-node": "9.1.1",
"ts-prune": "0.10.3",
Expand Down
Loading

2 comments on commit dafc5a6

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-a5h82ird1-elementl.vercel.app

Built with commit dafc5a6.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-fs51wkf0u-elementl.vercel.app

Built with commit dafc5a6.
This pull request is being automatically deployed with vercel-action

Please sign in to comment.