Fix test - need to pass dynamicPartitionsDefinitionName

dagster-io · Aug 7, 2024 · e1dab2e · e1dab2e
1 parent da760e7
commit e1dab2e
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/...gster-ui/packages/ui-core/src/assets/__tests__/LaunchAssetChoosePartitionsDialog.test.tsx b/...gster-ui/packages/ui-core/src/assets/__tests__/LaunchAssetChoosePartitionsDialog.test.tsx
@@ -9,6 +9,7 @@ import {
   buildAddDynamicPartitionSuccess,
   buildAssetKey,
   buildAssetNode,
+  buildDimensionDefinitionType,
   buildDimensionPartitionKeys,
   buildMultiPartitionStatuses,
   buildPartitionDefinition,
@@ -127,6 +128,7 @@ describe('launchAssetChoosePartitionsDialog', () => {
     const savePartitionButton = screen.getByTestId('save-partition-button');
     userEvent.click(savePartitionButton);
 
+    // Verify that it refreshes asset health after partition is added
     await waitFor(() => {
       expect(assetASecondQueryMockResult).toHaveBeenCalled();
     });
@@ -150,7 +152,18 @@ function buildAsset(name: string, dynamicPartitionKeys: string[]) {
       }),
     ],
     partitionDefinition: buildPartitionDefinition({
-      name: 'foo',
+      name: 'not-foo',
+      dimensionTypes: [
+        buildDimensionDefinitionType({
+          name: 'a',
+          type: PartitionDefinitionType.DYNAMIC,
+          dynamicPartitionsDefinitionName: 'foo',
+        }),
+        buildDimensionDefinitionType({
+          name: 'b',
+          type: PartitionDefinitionType.TIME_WINDOW,
+        }),
+      ],
     }),
     assetPartitionStatuses: buildMultiPartitionStatuses({
       primaryDimensionName: 'b',

diff --git a/js_modules/dagster-ui/packages/ui-core/src/workspace/VirtualizedAssetTable.tsx b/js_modules/dagster-ui/packages/ui-core/src/workspace/VirtualizedAssetTable.tsx
@@ -5,7 +5,7 @@ import {VirtualizedAssetCatalogHeader, VirtualizedAssetRow} from './VirtualizedA
 import {buildRepoAddress} from './buildRepoAddress';
 import {AssetTableFragment} from '../assets/types/AssetTableFragment.types';
 import {AssetViewType} from '../assets/useAssetView';
-import {AssetKeyInput, DefinitionTag} from '../graphql/types';
+import {DefinitionTag} from '../graphql/types';
 import {StaticSetFilter} from '../ui/BaseFilters/useStaticSetFilter';
 import {Container, Inner} from '../ui/VirtualizedTable';
 
@@ -84,8 +84,6 @@ export const VirtualizedAssetTable = (props: Props) => {
               return buildRepoAddress(repository.name, repository.location.name);
             };
 
-            const wipeableAssets = row.type === 'folder' ? row.assets : [row.asset];
-
             return (
               <VirtualizedAssetRow
                 key={key}

diff --git a/js_modules/dagster-ui/packages/ui-core/src/workspace/VirtualizedRepoAssetTable.tsx b/js_modules/dagster-ui/packages/ui-core/src/workspace/VirtualizedRepoAssetTable.tsx
@@ -103,7 +103,7 @@ export const VirtualizedRepoAssetTable = ({repoAddress, assets}: Props) => {
                 start={start}
                 checked={false}
                 onToggleChecked={() => {}}
-                onWipe={() => {}}
+                onRefresh={() => {}}
               />
             );
           })}