change non-executable to external

dagster-io · Oct 9, 2023 · ee554fb · ee554fb
1 parent d7147cc
commit ee554fb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeDefinition.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/AssetNodeDefinition.tsx
@@ -298,7 +298,7 @@ const DescriptionAnnotations: React.FC<{
     {assetNode.isSource ? (
       <Caption style={{lineHeight: '16px'}}>Source Asset</Caption>
     ) : !assetNode.isExecutable ? (
-      <Caption style={{lineHeight: '16px'}}>Non-executable Asset</Caption>
+      <Caption style={{lineHeight: '16px'}}>External Asset</Caption>
     ) : undefined}
   </Box>
 );

diff --git a/js_modules/dagster-ui/packages/ui-core/src/assets/LaunchAssetExecutionButton.tsx b/js_modules/dagster-ui/packages/ui-core/src/assets/LaunchAssetExecutionButton.tsx
@@ -166,7 +166,7 @@ export function executionDisabledMessageForAssets(
     : assets.every((a) => a.isSource)
     ? 'Source assets cannot be materialized'
     : assets.every((a) => !a.isExecutable)
-    ? 'Non-executable assets cannot be materialized'
+    ? 'External assets cannot be materialized'
     : null;
 }
 
@@ -412,7 +412,7 @@ async function stateForLaunchingAssets(
   if (assets.some((x) => !x.isExecutable)) {
     return {
       type: 'error',
-      error: 'One or more non-executable assets are selected.',
+      error: 'One or more external assets are selected.',
     };
   }
 

diff --git a/...ules/dagster-ui/packages/ui-core/src/assets/__tests__/LaunchAssetExecutionButton.test.tsx b/...ules/dagster-ui/packages/ui-core/src/assets/__tests__/LaunchAssetExecutionButton.test.tsx
@@ -129,7 +129,7 @@ describe('LaunchAssetExecutionButton', () => {
       expect(button).toBeDisabled();
 
       userEvent.hover(button);
-      expect(await screen.findByText('Non-executable assets cannot be materialized')).toBeDefined();
+      expect(await screen.findByText('External assets cannot be materialized')).toBeDefined();
     });
   });