Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[graphql] support async resolvers #14915

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[graphql] support async resolvers #14915

merged 1 commit into from
Dec 1, 2023

Conversation

alangenfeld
Copy link
Member

@alangenfeld alangenfeld commented Jun 22, 2023 •
edited
Loading

changes how the root graphql execution is invoked to support async resolvers, unlocking the ability to use something like DataLoader https://docs.graphene-python.org/en/latest/execution/dataloader/ to effectively batch request instead of issuing them serially.

How I Tested These Changes

added test

did some quick py-spy profiling to make sure nothing stood out

@alangenfeld
Copy link
Member Author

alangenfeld commented Jun 22, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alangenfeld alangenfeld force-pushed the al/06-22-_graphql_support_async_resolvers branch from 18690a8 to 7a4e83d Compare November 28, 2023 18:57
@github-actions GitHub Actions
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-c6hqkbs1k-elementl.vercel.app
https://al-06-22--graphql-support-async-resolvers.components-storybook.dagster-docs.io

Built with commit 7a4e83d.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-g1lbsp81b-elementl.vercel.app
https://al-06-22--graphql-support-async-resolvers.core-storybook.dagster-docs.io

Built with commit b58ce55.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-nw54cuoik-elementl.vercel.app
https://al-06-22--graphql-support-async-resolvers.dagster.dagster-docs.io

Direct link to changed pages:

@alangenfeld alangenfeld requested a review from prha November 28, 2023 20:02
@alangenfeld
Copy link
Member Author

Found this in my pr queue stale from last time this got asked about in the summer. Theres no planned uses of this that im aware of but wanted to blow the dust off and get the tests passing.

@alangenfeld alangenfeld force-pushed the al/06-22-_graphql_support_async_resolvers branch from 7a4e83d to b58ce55 Compare November 28, 2023 20:16
prha
prha approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@prha prha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's pretty cool that this works.

@alangenfeld alangenfeld merged commit 2e69628 into master Dec 1, 2023
3 checks passed
@alangenfeld alangenfeld deleted the al/06-22-_graphql_support_async_resolvers branch December 1, 2023 16:17
@alangenfeld alangenfeld mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prha prha prha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alangenfeld @prha