Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add MaterializeResult #15932

Merged
merged 1 commit into from
Aug 25, 2023
Merged

add MaterializeResult #15932

merged 1 commit into from
Aug 25, 2023

Conversation

alangenfeld
Copy link
Member

The latest evolution of #14931 & #15392 intentionally aligned with #15928 this PR adds support for a new "Result" return type from assets that do not deal with "Outputs" to be able to communicate materialization metadata.

How I Tested These Changes

added tests.

@alangenfeld alangenfeld requested review from sryza and schrockn August 18, 2023 15:54
@alangenfeld
Copy link
Member Author

alangenfeld commented Aug 18, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alangenfeld alangenfeld force-pushed the al/08-18-add_MaterializeResult branch from 94edbff to 07c1e27 Compare August 18, 2023 15:55
sryza
sryza reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

python_modules/dagster/dagster/_core/execution/plan/execute_step.py Outdated Show resolved Hide resolved
python_modules/dagster/dagster/_core/definitions/result.py Show resolved Hide resolved
schrockn
schrockn reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited about this + AssetCheckResult

schrockn
schrockn previously requested changes Aug 18, 2023
View reviewed changes
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve docs per Sandy and I think this is good to go

@alangenfeld alangenfeld force-pushed the al/08-18-add_MaterializeResult branch from 07c1e27 to ed7d3ce Compare August 21, 2023 15:14
This was referenced Aug 21, 2023
Merged
Closed
@alangenfeld alangenfeld dismissed schrockn’s stale review August 21, 2023 15:14

docstrings added / updated

@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited
Loading

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-1gmlzfs70-elementl.vercel.app
https://al-08-18-add-MaterializeResult.core-storybook.dagster-docs.io

Built with commit 9824b63.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-r53fzvl12-elementl.vercel.app
https://al-08-18-add-MaterializeResult.dagster.dagster-docs.io

Direct link to changed pages:

@alangenfeld alangenfeld force-pushed the al/08-18-add_MaterializeResult branch 4 times, most recently from d69be9b to 00c9050 Compare August 22, 2023 17:20
schrockn
schrockn approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@schrockn schrockn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Excited to see this land

@alangenfeld alangenfeld force-pushed the al/08-18-add_MaterializeResult branch 2 times, most recently from 36d9651 to 8b520e7 Compare August 24, 2023 16:59
@github-actions
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-5aieq2fyj-elementl.vercel.app
https://al-08-18-add-MaterializeResult.components-storybook.dagster-docs.io

Built with commit 8b520e7.
This pull request is being automatically deployed with vercel-action

@alangenfeld alangenfeld force-pushed the al/08-18-add_MaterializeResult branch from 8b520e7 to 9824b63 Compare August 25, 2023 18:55
@github-actions
Copy link

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-gywm5orh7-elementl.vercel.app
https://al-08-18-add-MaterializeResult.dagster-university.dagster-docs.io

Built with commit 9824b63.
This pull request is being automatically deployed with vercel-action

@alangenfeld alangenfeld merged commit 711d2e5 into master Aug 25, 2023
@alangenfeld alangenfeld deleted the al/08-18-add_MaterializeResult branch August 25, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sryza sryza sryza left review comments

@schrockn schrockn schrockn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alangenfeld @sryza @schrockn