[1/n][pythonic config] Restructure Pythonic config & resources into modules #16434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
benpankow
changed the title
benpankow
force-pushed
the
benpankow/restructure-pythonic-config-module
branch
from
9620faf to
4168aea
Compare
This was referenced Sep 12, 2023
schrockn
approved these changes
Sep 12, 2023
benpankow
force-pushed
the
benpankow/restructure-pythonic-config-module
branch
from
4168aea to
f00ba77
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit f00ba77. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit f00ba77. |
zyd14
pushed a commit
to zyd14/dagster
that referenced
this pull request
Sep 15, 2023
…odules (dagster-io#16434) ## Summary PR stack which re-implements dagster-io#16257, in hopes of making it easier to review. This PR restructures the pythonic resources+config module into a few smaller, easier to grasp files - one for the "Config" class, one for Resources, one for IO managers, and one for misc Pydantic & Dagster Config Type conversion utilities. ## Test Plan Impl does not change, existing unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR stack which re-implements #16257, in hopes of making it easier to review.
This PR restructures the pythonic resources+config module into a few smaller, easier to grasp files - one for the "Config" class, one for Resources, one for IO managers, and one for misc Pydantic & Dagster Config Type conversion utilities.
Test Plan
Impl does not change, existing unit tests.