allow duplicate AssetDeps passed to deps if those AssetDeps are the same #16720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
jamiedemaria
changed the title
yuhan
approved these changes
Sep 27, 2023
python_modules/dagster/dagster/_core/definitions/decorators/asset_decorator.py
Outdated
Show resolved
Hide resolved
jamiedemaria
force-pushed
the
jamie/asset-dep-fixes
branch
from
6940587 to
4543a2e
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 4543a2e. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 4543a2e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
With the switch to using AssetDeps, if a user passes the same asset twice to
deps, they now get an exception. Older versions of the code silently deduplicated the dependencies. This PR goes back to the previous behavior as long as theAssetDepsare the same (ie have the same partition mapping)How I Tested These Changes
new unit test