Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Asset graph] Usability improvements #16902

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Sep 29, 2023

Summary & Motivation

Requests from josh:

  • Can we rename “Folder view” to “Group view” and use the asset group icon
  • On an asset group page is it possible to auto expand the list of asset in the group/folder view? Or maybe this should always just be a list if there is only one group?
  • Can we change the default cursor on the graph to be cursor: grab and cursor: grabbing on drag? Hovering over an asset should change it to cursor: pointer
  • Fix the alignment of the reload definitions button
  • change the placeholder text here from “Search” to “Jump to…”

How I Tested These Changes

locally

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-rewguav5c-elementl.vercel.app
https://salazarm-asset-graph-nits-2.core-storybook.dagster-docs.io

Built with commit fe82478.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Sep 29, 2023

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-9a2t9ad4l-elementl.vercel.app
https://salazarm-asset-graph-nits-2.components-storybook.dagster-docs.io

Built with commit fe82478.
This pull request is being automatically deployed with vercel-action

@salazarm salazarm requested a review from braunjj September 29, 2023 06:58
@salazarm salazarm merged commit 9ec0f16 into master Sep 29, 2023
@salazarm salazarm deleted the salazarm/asset-graph-nits-2 branch September 29, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants