Eliminate dead code in dagster_pipes #16907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
schrockn
force-pushed
the
dead-pipes-code
branch
from
b5fbbcd to
8bb5531
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 8bb5531. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 8bb5531. |
|
… On Fri, Sep 29, 2023 at 4:00 PM, Sean Mackesey < ***@***.*** > wrote:
***@***.**** approved this pull request.
I added a few validations here that use some of these functions:
#16922 ( #16922 )
If you stack on top of that (or just wait to merge) and then merge this
removing the remaining unused functions then it's all good.
—
Reply to this email directly, view it on GitHub (
#16907 (review)
) , or unsubscribe (
https://github.com/notifications/unsubscribe-auth/AG3IK6OZ2SBY3UN7AQEOW6TX44SENANCNFSM6AAAAAA5MQ737Q
).
You are receiving this because you authored the thread. Message ID: <dagster-io/dagster/pull/16907/review/1651407151
@ github. com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Dead code in dagster_pipes. Delete.
How I Tested These Changes
BK