Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ez][Asset graph] revert padding change #16942

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Oct 2, 2023

Summary & Motivation

Reverting a padding change I made that tried to solve one problem but created another. I solved the original problem in a separate PR.

before:
Screenshot 2023-10-02 at 8 37 19 AM

after:
Screenshot 2023-10-02 at 8 36 44 AM

How I Tested These Changes

@salazarm salazarm requested review from bengotow and hellendag October 2, 2023 12:38
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-gwj1tnius-elementl.vercel.app
https://salazarm-asset-graph-padding.components-storybook.dagster-docs.io

Built with commit 60b476c.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-5ur8sgbdl-elementl.vercel.app
https://salazarm-asset-graph-padding.core-storybook.dagster-docs.io

Built with commit 60b476c.
This pull request is being automatically deployed with vercel-action

@salazarm salazarm merged commit efea247 into master Oct 2, 2023
2 checks passed
@salazarm salazarm deleted the salazarm/asset-graph-padding branch October 2, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants