[MaterializeResult] more direct invocation tests & fixes #16958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
schrockn
approved these changes
Oct 2, 2023
alangenfeld
force-pushed
the
al/10-02-_MaterializeResult_more_direct_invocation_tests_fixes
branch
2 times, most recently
from
58f6097 to
a59c4e0
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b0cd32b. |
alangenfeld
force-pushed
the
al/10-02-_MaterializeResult_more_direct_invocation_tests_fixes
branch
from
a59c4e0 to
b0cd32b
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit b0cd32b. |
alangenfeld
deleted the
al/10-02-_MaterializeResult_more_direct_invocation_tests_fixes
branch
Ramshackle-Jamathon
pushed a commit
that referenced
this pull request
Oct 6, 2023
update more of the test suite to do direct invocation next to the existing core execution coverage. Fixes a couple of small issues accodingly. ## How I Tested These Changes ran the test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update more of the test suite to do direct invocation next to the existing core execution coverage. Fixes a couple of small issues accodingly.
How I Tested These Changes
ran the test suite