[ui] Use location-based feature flag on partitions dialog #17017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellendag
force-pushed
the
dish/feature-flag-radios
branch
from
3ad91a8 to
f2bc6ec
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit de2afe6. |
gibsondan
approved these changes
Oct 5, 2023
hellendag
force-pushed
the
dish/feature-flag-radios
branch
from
f2bc6ec to
41d4a86
Compare
hellendag
force-pushed
the
dish/feature-flag-radios
branch
from
41d4a86 to
de2afe6
Compare
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
benpankow
pushed a commit
that referenced
this pull request
Oct 9, 2023
## Summary & Motivation Add a feature flag utility to read flags from location entries, use it to gate the `SHOW_SINGLE_RUN_BACKFILL_TOGGLE` UI in the materialization partition dialog. <img width="758" alt="Screenshot 2023-10-04 at 5 41 44 PM" src="https://github.com/dagster-io/dagster/assets/2823852/4f51346d-ff95-4af4-be10-95d07a4918d9"> ## How I Tested These Changes Jest to verify flag checking. View http://localhost:3000/locations/partitioned_assets_repository@dagster_test.toys.repo/asset-groups/default/lineage/hourly_asset1, materialize. Verify that the radio container is not rendered. Force the flag utility hook to return true, verify that the radio container is rendered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Add a feature flag utility to read flags from location entries, use it to gate the
SHOW_SINGLE_RUN_BACKFILL_TOGGLEUI in the materialization partition dialog.How I Tested These Changes
Jest to verify flag checking.
View http://localhost:3000/locations/partitioned_assets_repository@dagster_test.toys.repo/asset-groups/default/lineage/hourly_asset1, materialize. Verify that the radio container is not rendered.
Force the flag utility hook to return true, verify that the radio container is rendered.