Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for insights #17053

Merged
merged 19 commits into from
Oct 10, 2023
Merged

Add docs for insights #17053

merged 19 commits into from
Oct 10, 2023

Conversation

shalabhc
Copy link
Contributor

@shalabhc shalabhc commented Oct 5, 2023

Insights is a new dagster cloud feature and this provides and overview as well as some guides for exporting metrics and integrating external metrics.

Copy link
Contributor Author

shalabhc commented Oct 5, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@shalabhc shalabhc force-pushed the shalabhc/insights-docs branch from 3e32d3c to 0cea6b3 Compare October 5, 2023 23:55
@shalabhc shalabhc force-pushed the shalabhc/insights-docs branch from 2b615e3 to e798a11 Compare October 9, 2023 04:45
@shalabhc shalabhc requested a review from benpankow October 9, 2023 16:03
@shalabhc shalabhc force-pushed the shalabhc/insights-docs branch from e798a11 to b3a3e75 Compare October 9, 2023 16:13
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-qf5998tnw-elementl.vercel.app
https://shalabhc-insights-docs.components-storybook.dagster-docs.io

Built with commit b3a3e75.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-rltj0g15t-elementl.vercel.app
https://shalabhc-insights-docs.core-storybook.dagster-docs.io

Built with commit b3a3e75.
This pull request is being automatically deployed with vercel-action

@shalabhc shalabhc force-pushed the shalabhc/insights-docs branch from b3a3e75 to ac4ecb9 Compare October 9, 2023 16:25
@shalabhc shalabhc marked this pull request as ready for review October 9, 2023 16:25
docs/content/dagster-cloud/insights.mdx Outdated Show resolved Hide resolved
docs/content/dagster-cloud/insights.mdx Outdated Show resolved Hide resolved
docs/content/dagster-cloud/insights.mdx Outdated Show resolved Hide resolved
shalabhc and others added 4 commits October 9, 2023 11:01
)

snowflake_insights_definitions = create_snowflake_insights_asset_and_schedule(
"2023-10-5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"2023-10-5",
start_date="2023-10-5",

mix of args/kwargs is a bit odd

Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shalabhc Back to you! We'll need to update the screenshots though - both of them are a bit fuzzy, and include the entire browser window (which is fine for review, but not release). LMK if you want help with this or for me to take a look in the AM.

I also moved the dbt + Snowflake instructions to their own guide. I did this b/c it seems we'll add support for other things later, and having everything on that one page will get overwhelming, quickly.

@elementljarredc elementljarredc merged commit e2b1006 into master Oct 10, 2023
1 check passed
@elementljarredc elementljarredc deleted the shalabhc/insights-docs branch October 10, 2023 05:08
erinkcochran87 added a commit that referenced this pull request Oct 10, 2023
Insights is a new dagster cloud feature and this provides and overview
as well as some guides for exporting metrics and integrating external
metrics.

---------

Co-authored-by: Ben Pankow <[email protected]>
Co-authored-by: Erin Cochran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants