[ui] Support for manually reporting materialization events from asset details #17091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairelin135
force-pushed
the
claire/gql-report-runless-asset-event
branch
from
d29c76a to
4f36358
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 17d0793. |
Base automatically changed from
claire/gql-report-runless-asset-event
to
master
October 9, 2023 16:46
bengotow
force-pushed
the
bengotow/gql-report-runless-asset-event
branch
from
b2e7459 to
de9c933
Compare
bengotow
force-pushed
the
bengotow/gql-report-runless-asset-event
branch
from
de9c933 to
c234330
Compare
salazarm
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design: https://www.figma.com/file/V1V87q5hW7Z6G8T3T1XbTn/Manual_AddEvent?type=design&node-id=12-30&mode=design&t=oNRAFHi3u6HhLuMo-0
Summary & Motivation
This PR adds a new option to the materialize dropdown on the asset details page. (and ONLY this copy of the button)
The new option opens a modal which allows you to manually record that an asset materialization has taken place. If the asset is partitioned, you can choose partitions from this modal and we pass the partition keys through to the mutation.
Events created in this manner seem to have a runId = "", and I'm using that to display a tag that says "Reported" in two places:
How I Tested These Changes
Just manual testing so far with partitioned and unpartitioned assets. Everything seems to work nicely once you have these in the system, the statuses of the partitions update as expected.
Will add a few jest tests for this but it sounds like we want to ship this ASAP so I may apply everyone's feedback first.