Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][pipes] - Modifying existing code page #17092
[docs][pipes] - Modifying existing code page #17092
Changes from all commits
2b54bfe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this line is a little confusing because of the word "orchestrate". I think it would be clearer to say:
"This guide talks about how to modify your code to send information back to Dagster. To schedule and automate this code through Dagster you will need to follow this guide ... "
Basically, I think of it as a two step process to get Dagster to run some existing code:
To me this checklist is currently hard to understand because it is split across guides, and the cross-refs don't really make it clear you need to do both steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back end forth on the sequence of pages a lot! I think you are exactly right about the two step process. The current split is indeed confusing because the two pages are kinda depend on each other - maybe, a better approach is to structure the guides to be similar to the dbt + dagster tutorial, where we rearrange this and #17096 to be 3 separate pages:
@erinkcochran87 what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slopp i'm experimenting a new structure for the subprocess docs here: #17108 - please let me know how you feel about the proposed new structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole section to me is fairly confusing and I think would make more sense if you had a sample of a dagster asset invoking the external code with pipes in it.
I get we're trying to target two different personas, but I think realistically for this this "existing external code" person to understand the guide, we need to show them at least psuedo code for how their code will be invoked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is confusing to me. The 'function' isn't your existing code per se... its a callout to some system to run your existing code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this go into too much detail? This seems like generalized Dagster documentation, rather than being about Pipes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erinkcochran87 and i landed on this because we thought the audience (stakeholders) to this page may not be familiar with dagster, so the writing here is intentionally to be felt like a subset of generalized dagster docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is a pipes process? Is this a new noun?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it'd be nice to show the entirety of the prior code snippet here to make it clearer what the small additional diff is... take it or leave it, but I think the
...
only saves us a few lines and in this case adds more mental work for me (what are we omitting) than it savesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we expecting some baseline familiarity with dagster? I'm not sure how much this reference link helps if we think a lot of non dagster users will be looking at this page