Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] [pipes] - Add Databricks integration guide #17114
[docs] [pipes] - Add Databricks integration guide #17114
Changes from 2 commits
1f2eb3a
85ff9bf
791cb7c
46286d5
a40e33e
7dfaf29
fb94fc5
1eb547f
45d312e
30acbe9
0d08f96
9cfbea9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Databricks resource" -> "Databricks Pipes client"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it (sort of?) functions like a resource, and is configured like one.
Resource
is a term Dagster users are already familiar with, whereas this is a new term. Do you feel strongly about changing this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"must include dagster-pipes" -> "Make the latest version of dagster-pipes on PyPI available in the task environment"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to specify the version here? Or would this automatically use the latest version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're the authority on style consistency so I leave to you, but IMO it's more clear to keep imports and the code using them together in one block/step. In fact I think the whole asset and imports should just be in one coherent code block, then if you want to requote later you do so in a smaller snippet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should attempt to formally document the various fields here. This is part of the Databricks API and has nothing to do with Dagster per se. We might just say something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, about that - did you find good documentation that describes how to do this? What I found was pretty light and didn't totally match up here. I also would prefer not to include these fields, but if we can't point to good documentation, I don't think it's a good experience for users of our integration.