[docs] Use https for sitemap URLs #17158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Adding @frasermarlow on here because it may have some implications for search engines. |
hellendag
force-pushed
the
dish/sitemap-https
branch
from
2544364 to
d334d7c
Compare
erinkcochran87
approved these changes
Oct 11, 2023
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-e6p9ugy57-elementl.vercel.app Direct link to changed pages: |
hellendag
force-pushed
the
dish/sitemap-https
branch
from
d334d7c to
a589b27
Compare
yuhan
pushed a commit
that referenced
this pull request
Oct 12, 2023
## Summary & Motivation I have a hunch that our search crawler is failing to make proper use of our sitemap.xml. I think it may be because the sitemap exclusively uses `http://` URLs instead of `https://`, even though all of these URLs will 307 -> 302 to `https`. I'm changing the sitemap generator to use `https` instead. ## How I Tested These Changes View sitemap.xml locally and in preview, verify that the URLs look correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
I have a hunch that our search crawler is failing to make proper use of our sitemap.xml. I think it may be because the sitemap exclusively uses
http://URLs instead ofhttps://, even though all of these URLs will 307 -> 302 tohttps.I'm changing the sitemap generator to use
httpsinstead.How I Tested These Changes
View sitemap.xml locally and in preview, verify that the URLs look correct.