Handle undefined assetChecksAvailable in current session #17170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 5c6e167. |
prha
approved these changes
Oct 12, 2023
salazarm
added a commit
that referenced
this pull request
Oct 12, 2023
## Summary & Motivation If you access a session from localStorage from before this release then this property won't exist. We correctly use the existential operator (?.) in [other places ](https://github.com/dagster-io/dagster/blob/45c5a47480b8f712d5c4c51e74213626d5061b79/js_modules/dagster-ui/packages/ui-core/src/launchpad/LaunchpadSession.tsx#L209)but looks like we forgot to use it here. ## How I Tested These Changes 1. Switched to release-1.5.2 2. Made a new launchpad config 3. Switched back to release-1.5.3 and saw the error: 4. <img width="1164" alt="Screenshot 2023-10-11 at 11 28 22 PM" src="https://github.com/dagster-io/dagster/assets/2286579/bfdec5bf-241d-429c-b64b-e4cae1f478da"> 5. Switched to this branch and saw the error go away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
If you access a session from localStorage from before this release then this property won't exist. We correctly use the existential operator (?.) in other places but looks like we forgot to use it here.
How I Tested These Changes