Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipes] pipes concept and subprocess - tweaks per dogfooding feedback #17185

Conversation

yuhan
Copy link
Contributor

@yuhan yuhan commented Oct 12, 2023

Summary & Motivation

addresses most of the feedback we got from the dogfooding session: https://app.markup.io/markup/92ab8637-41f4-4ebb-98cb-23da0e4efc44

a big one is it moves the Limitations section a bit down

How I Tested These Changes

vercel aliasing failed but preview generated here: https://dagster-docs-24jokdo0e-elementl.vercel.app/guides/dagster-pipes

@yuhan yuhan requested a review from erinkcochran87 as a code owner October 12, 2023 21:46
@yuhan
Copy link
Contributor Author

yuhan commented Oct 12, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@yuhan yuhan force-pushed the 10-12-_pipes_pipes_concept_and_subprocess_-_tweaks_per_dogfooding_feedback branch from b3131ec to 67c7015 Compare October 12, 2023 21:50
@yuhan yuhan requested a review from jamiedemaria October 12, 2023 21:50
Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@yuhan yuhan merged commit 82721cf into master Oct 12, 2023
1 check failed
@yuhan yuhan deleted the 10-12-_pipes_pipes_concept_and_subprocess_-_tweaks_per_dogfooding_feedback branch October 12, 2023 22:02
yuhan added a commit that referenced this pull request Oct 12, 2023
…#17185)

## Summary & Motivation
addresses most of the feedback we got from the dogfooding session:
https://app.markup.io/markup/92ab8637-41f4-4ebb-98cb-23da0e4efc44

a big one is it moves the Limitations section a bit down

## How I Tested These Changes
vercel aliasing failed but preview generated here:
https://dagster-docs-24jokdo0e-elementl.vercel.app/guides/dagster-pipes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants