Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Refactor RunActionsMenu.test #17243

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[ui] Refactor RunActionsMenu.test #17243

merged 1 commit into from
Oct 17, 2023

Conversation

hellendag
Copy link
Member

Summary & Motivation

Delete a TestProvider use case.

How I Tested These Changes

Lint, TS, jest.

@hellendag
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-d61kw0hvt-elementl.vercel.app
https://dish-test-provider.core-storybook.dagster-docs.io

Built with commit 69d3041.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, is this mostly to increase test speed?

@hellendag
Copy link
Member Author

nice, is this mostly to increase test speed?

Yeah, and to just keep chipping away at removing TestProvider in favor of MockedProvider.

@hellendag hellendag merged commit caf571a into master Oct 17, 2023
1 check passed
@hellendag hellendag deleted the dish/test-provider branch October 17, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants