[AssetLiveDataProvider] Retry asset keys that fail to fetch after the poll interval. #17393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 7b50b85. |
bengotow
approved these changes
Oct 27, 2023
salazarm
force-pushed
the
salazarm/asset-live-data-provider-try-catch
branch
from
ff6f463 to
7b50b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Currently if an asset key fails to fetch we never retry fetching it again because it gets stuck in the requested state. This PR fixes that and marks them as "fetched" when this happens. This has the consequence of (1) letting us move on to the next set of asset keys which could succeed and (2) it means we'll retry the failed asset keys again after the polling interval threshold is crossed.
How I Tested These Changes
jest. Locally threw an error and saw that we did end up retrying the failed asset keys after the polling interval was met.