[ui] Eliminate React.FC #17446
Merged
[ui] Eliminate React.FC #17446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 8bf8831. |
hellendag
force-pushed
the
dish/fc-cleanup
branch
from
9e1218a to
435d152
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 8bf8831. |
hellendag
commented
Oct 27, 2023
Comment on lines
+89
to
+101
| '@typescript-eslint/ban-types': [ | ||
| 'error', | ||
| { | ||
| types: { | ||
| 'React.FC': | ||
| 'Useless and has some drawbacks, see https://github.com/facebook/create-react-app/pull/8177', | ||
| 'React.FunctionComponent': | ||
| 'Useless and has some drawbacks, see https://github.com/facebook/create-react-app/pull/8177', | ||
| 'React.FunctionalComponent': | ||
| 'Preact specific, useless and has some drawbacks, see https://github.com/facebook/create-react-app/pull/8177', | ||
| }, | ||
| }, | ||
| ], |
hellendag
force-pushed
the
dish/fc-cleanup
branch
from
435d152 to
7dfe7fc
Compare
bengotow
approved these changes
Oct 27, 2023
hellendag
force-pushed
the
dish/fc-cleanup
branch
from
7dfe7fc to
8bf8831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Remove React.FC from JS packages, some by hand but mostly using https://github.com/gndelia/codemod-replace-react-fc-typescript.
In some places, I went in and manually tidied things to prevent huge whitespace shifts, especially around
React.memo.How I Tested These Changes
TS, lint, jest.