Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asset check factory docs #17515

Merged
merged 1 commit into from
Nov 1, 2023
Merged

asset check factory docs #17515

merged 1 commit into from
Nov 1, 2023

Conversation

johannkm
Copy link
Contributor

@johannkm johannkm commented Oct 31, 2023 •
edited
Loading

@johannkm
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@johannkm johannkm force-pushed the johann/10-31-asset_check_factory_docs branch from 2195c3a to 3047099 Compare October 31, 2023 15:29
@johannkm johannkm requested a review from sryza October 31, 2023 15:31
sryza
sryza reviewed Oct 31, 2023
View reviewed changes
examples/docs_snippets/docs_snippets/concepts/assets/asset_checks/factory.py
...


def make_checks(check_blobs: Sequence[Mapping[str, str]]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A return type would be helpful for understanding what this code is doing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I hadn't added AssetChecksDefinition to the top level imports yet, will fix

@johannkm johannkm force-pushed the johann/10-31-asset_check_factory_docs branch from 3047099 to 9e5769f Compare November 1, 2023 19:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-3kfhpwj1z-elementl.vercel.app
https://johann-10-31-asset-check-factory-docs.components-storybook.dagster-docs.io

Built with commit 9e5769f.
This pull request is being automatically deployed with vercel-action

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-r59azx6d3-elementl.vercel.app
https://johann-10-31-asset-check-factory-docs.core-storybook.dagster-docs.io

Built with commit 9e5769f.
This pull request is being automatically deployed with vercel-action

@johannkm johannkm merged commit 926b209 into master Nov 1, 2023
2 of 3 checks passed
@johannkm johannkm deleted the johann/10-31-asset_check_factory_docs branch November 1, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sryza sryza sryza approved these changes

@erinkcochran87 erinkcochran87 Awaiting requested review from erinkcochran87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johannkm @sryza