Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silence runtime experimental warnings from AssetCheckKey #17598

Merged

Conversation

johannkm
Copy link
Contributor

@johannkm johannkm commented Nov 1, 2023

This @experimental is being extremely noisy:

/Users/johann/dagster/python_modules/dagster/dagster/_core/host_representation/external_data.py:1128: ExperimentalWarning: Class `AssetCheckKey` is experimental. It may break in future versions, even between dot releases. To mute warnings for experimental functionality, invoke warnings.filterwarnings("ignore", category=dagster.ExperimentalWarning) or use one of the other methods described at https://docs.python.org/3/library/warnings.html#describing-warning-filters.

due to callsites like https://github.com/dagster-io/dagster/blob/johann/11-01-remove_experimental_from_AssetCheckKey/python_modules/dagster/dagster/_core/host_representation/external_data.py#L1127-L1128. This also takes place in the host side, so you can't silence it per #17520.

Seems easier to remove vs. remembering a with disable_dagster_warnings(): everywhere we instantiate this key, plus I think it's very unlikely this NT changes.

Closes #17520


Edit: updated to leave @experimental, but not emit runtime warnings

@johannkm
Copy link
Contributor Author

johannkm commented Nov 1, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@johannkm johannkm requested review from sryza and alangenfeld November 1, 2023 19:08
@sryza
Copy link
Contributor

sryza commented Nov 2, 2023

Curious if you have any concerns on this @schrockn ? Another option would be to document it as experimental, but take away the warnings.

This also takes place in the host side, so you can't silence it per #17520.

Should we disable all experimental warnings on host processes? It's hard to imagine a situation where they're useful.

plus I think it's very unlikely this NT changes.

It seems unlikely, but could possibly imagine the name changing.

@johannkm
Copy link
Contributor Author

johannkm commented Nov 2, 2023

If we want to keep it documented as experimental we can use @experimental(emit_runtime_warning=False)

@johannkm
Copy link
Contributor Author

johannkm commented Nov 2, 2023

Should we disable all experimental warnings on host processes? It's hard to imagine a situation where they're useful.

We could at least have a toggle, I'm not aware of anything currently

@johannkm johannkm force-pushed the johann/11-01-remove_experimental_from_AssetCheckKey branch from 18f5f3b to 460958a Compare November 2, 2023 17:57
@johannkm johannkm changed the title remove @experimental from AssetCheckKey silence runtime experimental warnings from AssetCheckKey Nov 2, 2023
Copy link

github-actions bot commented Nov 2, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-kp6calo45-elementl.vercel.app
https://johann-11-01-remove-experimental-from-AssetCheckKey.core-storybook.dagster-docs.io

Built with commit 460958a.
This pull request is being automatically deployed with vercel-action

@johannkm johannkm merged commit ab05b12 into master Nov 3, 2023
2 checks passed
@johannkm johannkm deleted the johann/11-01-remove_experimental_from_AssetCheckKey branch November 3, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants