silence runtime experimental warnings from AssetCheckKey #17598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This @experimental is being extremely noisy:
due to callsites like https://github.com/dagster-io/dagster/blob/johann/11-01-remove_experimental_from_AssetCheckKey/python_modules/dagster/dagster/_core/host_representation/external_data.py#L1127-L1128. This also takes place in the host side, so you can't silence it per #17520.
Seems easier to remove vs. remembering a
with disable_dagster_warnings():
everywhere we instantiate this key, plus I think it's very unlikely this NT changes.Closes #17520
Edit: updated to leave @experimental, but not emit runtime warnings