Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] dagster essentials - fix typo WeeklyPartitionDefinition to WeeklyPartitionsDefinition #18078

Merged

Conversation

cmpadden
Copy link
Contributor

@cmpadden cmpadden commented Nov 16, 2023

Summary & Motivation

Fixes typo of WeeklyPartitionsDefinition in problem statement; if a user copy and pastes this reference (like myself) they will be met with the error:

dagster._core.errors.DagsterImportError: Encountered ImportError: `cannot import name 'WeeklyPartitionDefinition' from 'dagster'

Reference: https://docs.dagster.io/_apidocs/partitions#dagster.WeeklyPartitionsDefinition

How I Tested These Changes

Viewed rendered markdown and confirmed typo fix.

Copy link
Contributor

@tacastillo tacastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and cleaning it up! I appreciate you!

I'll hold off on merging because I can't recall if this gets persisted into the official site automatically on CD. So gonna hold off until @erinkcochran87 gets a chance to share her voice

@erinkcochran87 erinkcochran87 merged commit aff4907 into dagster-io:master Nov 21, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants