Josh theme tweaks #18284
Merged
Josh theme tweaks #18284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 7eac026. |
hellendag
reviewed
Nov 27, 2023
| @@ -118,7 +118,7 @@ const SwitchIcon = ({checked, indeterminate, fillColor, disabled}: IconProps) => | |||
| width="20" | |||
| height="20" | |||
| rx="10" | |||
| fill={disabled ? colorBackgroundDisabled() : colorBackgroundDefault()} | |||
| fill={disabled ? colorAccentWhite() : colorAccentWhite()} | |||
There was a problem hiding this comment.
Suggested change
| fill={disabled ? colorAccentWhite() : colorAccentWhite()} | |
| fill={colorAccentWhite()} |
| @@ -3,7 +3,7 @@ import {Dialog as BlueprintDialog} from '@blueprintjs/core'; | |||
| import * as React from 'react'; | |||
| import styled, {createGlobalStyle} from 'styled-components'; | |||
|
|
|||
| import {colorAccentPrimary, colorBackgroundDefault} from '../theme/color'; | |||
| import {colorAccentPrimary, colorBackgroundDefault, colorDialogBackground} from '../theme/color'; | |||
|
|
||
| box-shadow: ${colorBorderDefault()} inset 0px 0px 0px 1px; | ||
| :hover { | ||
| ${colorBorderHover()} inset 0px 0px 0px 1px; |
There was a problem hiding this comment.
Suggested change
| ${colorBorderHover()} inset 0px 0px 0px 1px; | |
| box-shadow: ${colorBorderHover()} inset 0px 0px 0px 1px; |
| margin: 0; | ||
| transition: box-shadow 150ms; | ||
| transition: border 150ms; |
There was a problem hiding this comment.
I don't think this is correct -- aren't we using box-shadow instead of border?
| @@ -40,6 +40,7 @@ export enum ColorName { | |||
| BorderDefault = 'BorderDefault', | |||
| BorderHover = 'BorderHover', | |||
| BorderDisabled = 'BorderDisabled', | |||
| BorderFocussed = 'BorderFocussed', | |||
There was a problem hiding this comment.
BorderFocused for US English spelling
Comment on lines
+319
to
+320
| background={colorBackgroundLight() | ||
| } |
| @@ -30,7 +35,7 @@ export const GroupNodeNameAndRepo = ({group, minimal}: {minimal: boolean; group: | |||
| > | |||
| {withMiddleTruncation(name, {maxLength: 14})} | |||
| </div> | |||
| <div style={{fontSize: 20}}>{withMiddleTruncation(location, {maxLength: 21})}</div> | |||
| {/* <div style={{fontSize: 20}}>{withMiddleTruncation(location, {maxLength: 21})}</div> */} | |||
| icon: meltano, | ||
| content: 'Meltano', | ||
| }, | ||
| matplotlib: { | ||
| color: '#2B597C', | ||
| color: '#055998', |
There was a problem hiding this comment.
At some point we should turn these into rgba values.
| } | ||
| //$color={reduceColor ? color : textcolor} | ||
| $color={reversed ? colorAccentPrimary() : color} | ||
| // $color={reduceColor ? color : textcolor} |
|
Merging this, will update dish/palettes with fixes |
hellendag
pushed a commit
that referenced
this pull request
Nov 27, 2023
## Summary & Motivation Adds a bunch of small style tweaks to the dark and light themes ## How I Tested These Changes Booted up the UI and tried it
hellendag
pushed a commit
that referenced
this pull request
Nov 28, 2023
## Summary & Motivation Adds a bunch of small style tweaks to the dark and light themes ## How I Tested These Changes Booted up the UI and tried it
hellendag
pushed a commit
that referenced
this pull request
Nov 29, 2023
## Summary & Motivation Adds a bunch of small style tweaks to the dark and light themes ## How I Tested These Changes Booted up the UI and tried it
hellendag
pushed a commit
that referenced
this pull request
Nov 30, 2023
## Summary & Motivation Adds a bunch of small style tweaks to the dark and light themes ## How I Tested These Changes Booted up the UI and tried it
hellendag
pushed a commit
that referenced
this pull request
Nov 30, 2023
## Summary & Motivation Adds a bunch of small style tweaks to the dark and light themes ## How I Tested These Changes Booted up the UI and tried it
hellendag
pushed a commit
that referenced
this pull request
Nov 30, 2023
## Summary & Motivation Adds a bunch of small style tweaks to the dark and light themes ## How I Tested These Changes Booted up the UI and tried it
hellendag
pushed a commit
that referenced
this pull request
Nov 30, 2023
## Summary & Motivation Adds a bunch of small style tweaks to the dark and light themes ## How I Tested These Changes Booted up the UI and tried it
hellendag
pushed a commit
that referenced
this pull request
Dec 1, 2023
## Summary & Motivation Adds a bunch of small style tweaks to the dark and light themes ## How I Tested These Changes Booted up the UI and tried it
hellendag
pushed a commit
that referenced
this pull request
Dec 1, 2023
## Summary & Motivation Adds a bunch of small style tweaks to the dark and light themes ## How I Tested These Changes Booted up the UI and tried it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adds a bunch of small style tweaks to the dark and light themes
How I Tested These Changes
Booted up the UI and tried it