Enable serializing partitions subset on materialization planned event #18418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
clairelin135
force-pushed
the
claire/status-single-run-backfill
branch
from
37c822b to
315cc58
Compare
clairelin135
force-pushed
the
11-29-serialize_subset_on_event_first_stab
branch
from
ef66c9f to
bb3ff96
Compare
clairelin135
changed the base branch from
claire/status-single-run-backfill
to
master
clairelin135
force-pushed
the
11-29-serialize_subset_on_event_first_stab
branch
4 times, most recently
from
ee96526 to
c12261a
Compare
sryza
reviewed
Dec 4, 2023
clairelin135
force-pushed
the
11-29-serialize_subset_on_event_first_stab
branch
from
c12261a to
8214fd2
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 8214fd2. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 8214fd2. |
clairelin135
force-pushed
the
11-29-serialize_subset_on_event_first_stab
branch
from
8214fd2 to
a7211b9
Compare
sryza
reviewed
Dec 5, 2023
python_modules/dagster/dagster/_core/definitions/time_window_partitions.py
Outdated
Show resolved
Hide resolved
clairelin135
force-pushed
the
11-29-serialize_subset_on_event_first_stab
branch
from
21ca2e7 to
8bffa6b
Compare
clairelin135
force-pushed
the
11-29-serialize_subset_on_event_first_stab
branch
from
8bffa6b to
9007970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables serializing a partitions subset on the asset materialization planned event. It adds an optional
partitions_subsetfield that parallels the existingpartitionfield onAssetMaterializationPlannedData.Since we cannot query for partitions subsets events by partition key, the partitions subset is not mirrored to any columns, it only exists within the event body.