[ui] Use color-scheme to set light/dark controls and scrollbars #18503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 3137fab. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 3137fab. |
salazarm
approved these changes
Dec 5, 2023
|
This is great! |
zyd14
pushed a commit
to zyd14/dagster
that referenced
this pull request
Jan 20, 2024
…ter-io#18503) ## Summary & Motivation Use the `color-scheme` CSS property to apply theme styles to controls and scrollbars. https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme <img width="470" alt="Screenshot 2023-12-05 at 9 44 08 AM" src="https://github.com/dagster-io/dagster/assets/2823852/d5b4a001-2c84-4c77-954f-218499ad1498"> <img width="451" alt="Screenshot 2023-12-05 at 9 43 49 AM" src="https://github.com/dagster-io/dagster/assets/2823852/3bd62648-3a8a-4168-8082-767f30770f1d"> ## How I Tested These Changes Force scrollbar to appear for legacy, light, and dark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Use the
color-schemeCSS property to apply theme styles to controls and scrollbars. https://developer.mozilla.org/en-US/docs/Web/CSS/color-schemeHow I Tested These Changes
Force scrollbar to appear for legacy, light, and dark.