Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Op / asset graph node styling polish #18546

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

bengotow
Copy link
Collaborator

@bengotow bengotow commented Dec 6, 2023

Summary & Motivation

  • The shadow of asset nodes is larger than the box they're clipped into so you can see the edge of the shadow. I made the shadow a (non-standard) smaller one
Screenshot 2023-12-06 at 2 58 03 PM
  • The "stacked box" of dynamic ops still had the old border radius
image
  • The gray description box of op nodes has a border radius that is too large and there's a sliver of whitespace between it and the outer border (bottom left of box). This should be 6px since it's inside something with an 8px radius + 2px width. (Added a comment to this since we might change it again)
image
  • The op graph boxes used to have a hard left edge with no border radius where they touched their inputs / outputs. They're rounded now, which looks nice, but the IO boxes still had hard edges. I made it so these are always rounded unless there is more than one, in which case the middle ones are joined.
image

(New version below)

Screenshot 2023-12-06 at 3 12 33 PM
  • The asset nodes in legacy mode had an olive border - talked with Josh and changed it to blue200:
image

How I Tested These Changes

Just tested these visually in experimental light + dark modes

Copy link

github-actions bot commented Dec 6, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-48adfe17i-elementl.vercel.app
https://bengotow-nits-asset-graph.core-storybook.dagster-docs.io

Built with commit c3ac402.
This pull request is being automatically deployed with vercel-action

Copy link

github-actions bot commented Dec 6, 2023

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-h9mg5tglm-elementl.vercel.app
https://bengotow-nits-asset-graph.components-storybook.dagster-docs.io

Built with commit c3ac402.
This pull request is being automatically deployed with vercel-action

@bengotow bengotow merged commit f80b262 into master Dec 12, 2023
3 checks passed
@bengotow bengotow deleted the bengotow/nits-asset-graph branch December 12, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants