[ui] Clean up legacy theme, product tour #18938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 84efebc. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 84efebc. |
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jan 6, 2024
## Summary & Motivation Remove legacy theme and product tour now that themes have been out for a while. Default users to "System setting" theme if they haven't explicitly chosen Light or Dark. ## How I Tested These Changes Set my `dagster-theme` localStorage value to "Legacy", verify that I get the system theme. Repeat with "foo" and with the value deleted from localStorage, verify same. Set theme to "Light" and "Dark", verify that these work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Remove legacy theme and product tour now that themes have been out for a while. Default users to "System setting" theme if they haven't explicitly chosen Light or Dark.
How I Tested These Changes
Set my
dagster-themelocalStorage value to "Legacy", verify that I get the system theme. Repeat with "foo" and with the value deleted from localStorage, verify same. Set theme to "Light" and "Dark", verify that these work properly.