Policy evaluations frontend #19030
Merged
Policy evaluations frontend #19030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwenKephart
force-pushed
the
12-13-PoC_AssetConditionEvaluation_GQL
branch
2 times, most recently
from
a78da1a to
145dced
Compare
salazarm
force-pushed
the
salazarm/policy-evaluations-frontend
branch
from
d9dd487 to
05ff795
Compare
OwenKephart
force-pushed
the
12-13-PoC_AssetConditionEvaluation_GQL
branch
2 times, most recently
from
167ecf7 to
5d9cded
Compare
salazarm
force-pushed
the
salazarm/policy-evaluations-frontend
branch
from
3f1c184 to
8f4be90
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 8c6ca14. |
OwenKephart
force-pushed
the
12-13-PoC_AssetConditionEvaluation_GQL
branch
2 times, most recently
from
2e33f90 to
60462a5
Compare
salazarm
force-pushed
the
salazarm/policy-evaluations-frontend
branch
from
041d8ce to
ce75e38
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 8c6ca14. |
salazarm
changed the title
OwenKephart
force-pushed
the
12-13-PoC_AssetConditionEvaluation_GQL
branch
from
60462a5 to
8423af9
Compare
hellendag
reviewed
Jan 11, 2024
...agster-ui/packages/ui-core/src/assets/AutoMaterializePolicyPage/AutomaterializeLeftPanel.tsx
Show resolved
Hide resolved
...agster-ui/packages/ui-core/src/assets/AutoMaterializePolicyPage/AutomaterializeLeftPanel.tsx
Outdated
Show resolved
Hide resolved
...agster-ui/packages/ui-core/src/assets/AutoMaterializePolicyPage/AutomaterializeLeftPanel.tsx
Outdated
Show resolved
Hide resolved
...agster-ui/packages/ui-core/src/assets/AutoMaterializePolicyPage/AutomaterializeLeftPanel.tsx
Show resolved
Hide resolved
...core/src/assets/AutoMaterializePolicyPage/__fixtures__/AutoMaterializePolicyPage.fixtures.ts
Outdated
Show resolved
Hide resolved
...-core/src/assets/AutoMaterializePolicyPage/__stories__/AutoMaterializePolicyPage.stories.tsx
Show resolved
Hide resolved
...ui-core/src/assets/AutoMaterializePolicyPage/__stories__/AutomaterializeLeftList.stories.tsx
Show resolved
Hide resolved
...core/src/assets/AutoMaterializePolicyPage/__stories__/AutomaterializeMiddlePanel.stories.tsx
Show resolved
Hide resolved
...ules/dagster-ui/packages/ui-core/src/assets/AutoMaterializePolicyPage/flattenEvaluations.tsx
Outdated
Show resolved
Hide resolved
OwenKephart
force-pushed
the
12-13-PoC_AssetConditionEvaluation_GQL
branch
9 times, most recently
from
f7f8e2d to
1e6f107
Compare
OwenKephart
force-pushed
the
salazarm/policy-evaluations-frontend
branch
from
04c8c60 to
6372a2f
Compare
OwenKephart
force-pushed
the
12-13-PoC_AssetConditionEvaluation_GQL
branch
from
1e6f107 to
15cc440
Compare
OwenKephart
force-pushed
the
salazarm/policy-evaluations-frontend
branch
from
055b204 to
2320f10
Compare
OwenKephart
force-pushed
the
12-13-PoC_AssetConditionEvaluation_GQL
branch
from
78a294b to
3e884b3
Compare
hellendag
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Would love if the anys can be cleaned up in a followup by building a concrete value for the problematic interface. Even if the any values are just living in stories/tests/fixtures, it makes me itchy to have all type safety removed from those values in perpetuity.
...s/dagster-ui/packages/ui-core/src/assets/AutoMaterializePolicyPage/PolicyEvaluationTable.tsx
Outdated
Show resolved
Hide resolved
...-core/src/assets/AutoMaterializePolicyPage/__stories__/AutoMaterializePolicyPage.stories.tsx
Show resolved
Hide resolved
OwenKephart
force-pushed
the
12-13-PoC_AssetConditionEvaluation_GQL
branch
3 times, most recently
from
770cf4c to
9e9f0cd
Compare
OwenKephart
force-pushed
the
12-13-PoC_AssetConditionEvaluation_GQL
branch
from
9e9f0cd to
2d49f22
Compare
Base automatically changed from
12-13-PoC_AssetConditionEvaluation_GQL
to
master
January 19, 2024 21:53
PedramNavid
pushed a commit
that referenced
this pull request
Jan 26, 2024
## Summary & Motivation Adds the new Automation page based off the new figmas, Also adds a feature gate to allow reverting back the old page ## How I Tested These Changes Tested: - Viewing unpartitioned asset history - Viewing partitioned asset history and selection a partition to view - Viewing multi-partitioned asset history and selection a partition to view Tested turning on the feature gate and that the old experience still worked: <img width="533" alt="Screenshot 2024-01-10 at 5 16 38 PM" src="https://github.com/dagster-io/dagster/assets/2286579/3cbec0d3-328e-4f91-8748-242603e2bf37"> <img width="1373" alt="Screenshot 2024-01-10 at 5 26 00 PM" src="https://github.com/dagster-io/dagster/assets/2286579/ec195838-40e8-4091-8b27-6a90dcfe6d92"> <img width="1722" alt="Screenshot 2024-01-10 at 5 24 58 PM" src="https://github.com/dagster-io/dagster/assets/2286579/71d1c125-c4a7-47a4-b634-cc1b3ecb88d5"> <img width="1728" alt="Screenshot 2024-01-10 at 5 20 19 PM" src="https://github.com/dagster-io/dagster/assets/2286579/f07514f9-fa25-45b6-a76a-1bccf741f89b"> <img width="413" alt="Screenshot 2024-01-10 at 5 20 12 PM" src="https://github.com/dagster-io/dagster/assets/2286579/63293ec7-cf25-4dfc-812c-1905c001e346"> <img width="1728" alt="Screenshot 2024-01-10 at 5 17 32 PM" src="https://github.com/dagster-io/dagster/assets/2286579/506377d1-9dfe-4be9-93e3-b1b6ed710f80"> --------- Co-authored-by: Owen Kephart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Adds the new Automation page based off the new figmas,
Also adds a feature gate to allow reverting back the old page
How I Tested These Changes
Tested:
Tested turning on the feature gate and that the old experience still worked:
