[ui] Skip dimension matching check when dynamic partition added #19106
Conversation
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
clairelin135
force-pushed
the
01-09-claire/add-flag-to-skip-dimension-matching-check
branch
from
7ef410f to
464c840
Compare
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit c1d0139. |
clairelin135
force-pushed
the
01-09-claire/add-flag-to-skip-dimension-matching-check
branch
2 times, most recently
from
edfc598 to
8d4047e
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 655676b. |
clairelin135
force-pushed
the
01-09-claire/add-flag-to-skip-dimension-matching-check
branch
from
8d4047e to
852f133
Compare
| @@ -49,6 +49,9 @@ export class ErrorBoundary extends React.Component<ErrorBoundaryProps, ErrorBoun | |||
| } | |||
|
|
|||
| componentDidCatch(error: Error, info: any) { | |||
| if (typeof jest !== 'undefined') { | |||
There was a problem hiding this comment.
This ensures that in test cases an error is thrown instead of caught
clairelin135
force-pushed
the
01-09-claire/add-flag-to-skip-dimension-matching-check
branch
from
1f6bf8a to
c448faf
Compare
| expect(assetASecondQueryMockResult).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| expect(errorMock).not.toHaveBeenCalled(); |
There was a problem hiding this comment.
We can remove this expectation since we didn't use it, we relied on the error being thrown to fail the test as opposed to relying on an assertion failing to fail to the test
There was a problem hiding this comment.
got it, sounds good
clairelin135
force-pushed
the
01-09-claire/add-flag-to-skip-dimension-matching-check
branch
2 times, most recently
from
655676b to
8868cb6
Compare
clairelin135
force-pushed
the
01-09-claire/add-flag-to-skip-dimension-matching-check
branch
from
8868cb6 to
c1d0139
Compare
clairelin135
deleted the
01-09-claire/add-flag-to-skip-dimension-matching-check
branch
Fixes #17380.
Users were seeing the
Attempting to show unified asset health for assets with dimension of different lengthserror because theusePartitionHealthDataquery makes a separate request for partitions per asset, updating the state after each asset's request. When 2 assets are selected, the first request returns a response including the new partition, causing the error because the second asset's request has not returned yet.Because the
LaunchAssetChoosePartitionsDialogcomponent already has an existing check to assert that each root partitions def in the asset selection is the same, we can skip the internal check. This PR adds a flag to bypass the "dimensions of different lengths" check.Adds a test to preserve this behavior.