-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prototype] AssetExecutionContext partition methods on sub context #19236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2024
Merged
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 17, 2024 21:13
38b66f9
to
50c80ab
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 17, 2024 21:13
53676ac
to
3db0d20
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 18, 2024 15:55
50c80ab
to
1fee854
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 18, 2024 15:55
3db0d20
to
9405338
Compare
This was referenced Jan 18, 2024
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 19, 2024 16:38
1fee854
to
558590d
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 19, 2024 16:38
9405338
to
4cde14d
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 19, 2024 19:09
558590d
to
bcc9cab
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 19, 2024 19:09
4cde14d
to
4963964
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 19, 2024 20:13
bcc9cab
to
af681dc
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 19, 2024 20:13
4963964
to
c583b85
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 23, 2024 00:11
af681dc
to
3016287
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 23, 2024 00:11
c583b85
to
e0845f3
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 26, 2024 19:10
3016287
to
04fd627
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 26, 2024 19:10
e0845f3
to
fa03263
Compare
This was referenced Jan 26, 2024
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 26, 2024 20:05
04fd627
to
0e1fc3e
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 26, 2024 20:05
fa03263
to
5621118
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 15:39
0e1fc3e
to
dc6edf0
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 29, 2024 15:39
5621118
to
b0b01ba
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 16:30
dc6edf0
to
ccc4260
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 29, 2024 16:30
b0b01ba
to
3b9df09
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 17:26
ccc4260
to
f416c05
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 29, 2024 17:26
3b9df09
to
7194e6f
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 18:16
f416c05
to
51d46aa
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 29, 2024 18:16
7194e6f
to
529b017
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 19:44
51d46aa
to
2670364
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 29, 2024 19:44
529b017
to
b526d68
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 20:03
2670364
to
2660075
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 29, 2024 20:03
b526d68
to
6676a12
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 30, 2024 17:23
2660075
to
a5828e1
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 30, 2024 17:23
6676a12
to
fbe85cf
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 30, 2024 20:19
a5828e1
to
f5be566
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-3
branch
from
January 30, 2024 20:19
fbe85cf
to
7624561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR is a prototype for a potential API for partition methods on the
AssetExecutionContext
. This version moves all of the partition related properties and methods to aPartitionContext
object so that they are grouped and made a more distinct from other context methodsHooli PR - dagster-io/hooli-data-eng-pipelines#61
DOP PR - https://github.com/dagster-io/internal/pull/7931
Nice things about this design:
PartitionContext
.issues with this API design:
partition
. But the removal of some of thepartitions
may sacrifice clarityHow I Tested These Changes