chore(prettier): add @trivago/prettier-plugin-sort-imports
#19281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit df8a9db. |
rexledesma
force-pushed
the
rl/add-eslint-sort-imports
branch
from
ed6a2b6 to
8454c30
Compare
rexledesma
changed the title
sort-imports rule@trivago/prettier-plugin-sort-imports
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit df8a9db. |
rexledesma
force-pushed
the
rl/add-eslint-sort-imports
branch
2 times, most recently
from
62f12d7 to
4a0695f
Compare
rexledesma
force-pushed
the
rl/add-eslint-sort-imports
branch
from
4a0695f to
df8a9db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Follow https://github.com/trivago/prettier-plugin-sort-imports and enable sorting of
*.tsx,*.ts,*.jsimports by default.We remove the existing
sort-orderrules from eslint, to defer formatting to prettier. For prettier config, we addimportOrderand put@dagster-ioimports and relative imports into their own group. Feel free to suggest other groups if needed.Alternatively, we could have set this in eslint. Originally, I followed https://medium.com/weekly-webtips/how-to-sort-imports-like-a-pro-in-typescript-4ee8afd7258a to do just this. However, organizing code imports is more of a formatting concern, so I went back to prettier.
How I Tested These Changes
yarn format, added bk step to enforce prettier