[daggy-u] update usage of context.add_output_metadata with MaterializeResult
#19575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
docs/dagster-university/pages/dagster-essentials/extra-credit/asset-metadata-as-markdown.md
Outdated
Show resolved
Hide resolved
...university/pages/dagster-essentials/extra-credit/coding-practice-metadata-taxi-zones-file.md
Show resolved
Hide resolved
docs/dagster-university/pages/dagster-essentials/extra-credit/materialization-metadata.md
Outdated
Show resolved
Hide resolved
…asset-metadata-as-markdown.md Co-authored-by: Erin Cochran <[email protected]>
|
@erinkcochran87 thank you for the feedback - I've made changes to address your comments. Let me know if there is anything else! |
|
@erinkcochran87, have you experienced failed Vercel aliases like this in the past? My theory is that it has to do with the branch name generated by Graphite, but I'm not 100% certain. |
|
@cmpadden I have no idea - I don't use Graphite 😬 |
erinkcochran87
approved these changes
Feb 6, 2024
Base automatically changed from
02-02-_dagster_u_bump_project_dagster_university_start_to_1.6._
to
master
February 6, 2024 17:49
cmpadden
deleted the
02-02-_daggy-u_update_usage_of_context.add_output_metadata_with_MaterializeResult_
branch
rexledesma
pushed a commit
that referenced
this pull request
Feb 9, 2024
…lizeResult` (#19575) ## Summary & Motivation With Dagster University being upgraded to v1.6, we should update our usage of `context.add_output_metadata` to returning a `MaterializeResult` with the `metadata` defined as a parameter. The corresponding changes to `project-dagster-university` can be found here: dagster-io/project-dagster-university#8 ## How I Tested These Changes --------- Co-authored-by: Erin Cochran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
With Dagster University being upgraded to v1.6, we should update our usage of
context.add_output_metadatato returning aMaterializeResultwith themetadatadefined as a parameter.The corresponding changes to
project-dagster-universitycan be found here:dagster-io/project-dagster-university#8
How I Tested These Changes