Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[daggy-u] [dbt] - Lesson 4, fetch your run artifacts #19968

Merged

Conversation

tacastillo
Copy link
Contributor

@tacastillo tacastillo commented Feb 22, 2024

Summary & Motivation

Making this a separate PR that folds into the larger LEsson 4 PR so I don't ruin your great writing with my dirty cruft.

How I Tested These Changes

@tacastillo
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@tacastillo tacastillo marked this pull request as ready for review February 22, 2024 02:57
@tacastillo tacastillo force-pushed the erin/dev-58-dbt-lesson-4 branch from d854863 to 69ee496 Compare February 22, 2024 02:59
@tacastillo tacastillo force-pushed the 02-21-_du-dbt_fetch_your_run_artifacts branch from 41c1df3 to b8ec5c7 Compare February 22, 2024 02:59
Copy link

github-actions bot commented Feb 22, 2024

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-onvvtx3qz-elementl.vercel.app
https://02-21--du-dbt-fetch-your-run-artifacts.dagster-university.dagster-docs.io

Built with commit a1ff875.
This pull request is being automatically deployed with vercel-action

@erinkcochran87 erinkcochran87 changed the title [du-dbt] fetch your run artifacts [daggy-u] [dbt] - Lesson 4, fetch your run artifacts Feb 23, 2024
@@ -0,0 +1,53 @@
---
title: 'Lesson 4: Customizing your execution'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this title specific, like "Customizing dbt's execution"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I get what you're saying and I think this could be worded better, but to nit pick it to the utmost extent, we aren't customizing how dbt runs, but rather what happens within Dagster after dbt runs. wdyt?

context.log.debug(result["compiled_code"])
```

Once you've made these changes, restart your code location and run any of your dbt models. You should see the compiled SQL code for each model in the logs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restart your code location

Specifically, kill dagster dev and then re-run, correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's one of the ways! The preferred ways would be either pressing the Reload Definitions button or pressing Option+Shift+R

@erinkcochran87 erinkcochran87 added the area: dagster-university Related to Dagster University label Feb 23, 2024
@tacastillo tacastillo merged commit 9e3ab28 into erin/dev-58-dbt-lesson-4 Feb 26, 2024
1 of 2 checks passed
@tacastillo tacastillo deleted the 02-21-_du-dbt_fetch_your_run_artifacts branch February 26, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dagster-university Related to Dagster University
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants