-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[embedded-elt] add an example for the Sling Decorator #19999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
PedramNavid
requested review from
sryza,
cmpadden,
benpankow,
tacastillo and
rexledesma
February 23, 2024 05:44
PedramNavid
force-pushed
the
pdrm/sling-example
branch
from
February 23, 2024 05:45
c157bb5
to
3778a7a
Compare
PedramNavid
force-pushed
the
pdrm/sling-deprecate
branch
from
February 23, 2024 05:48
ecb39fe
to
82f9393
Compare
PedramNavid
force-pushed
the
pdrm/sling-example
branch
from
February 23, 2024 05:48
3778a7a
to
654f79d
Compare
cmpadden
reviewed
Feb 23, 2024
cmpadden
reviewed
Feb 23, 2024
cmpadden
reviewed
Feb 23, 2024
cmpadden
reviewed
Feb 23, 2024
cmpadden
reviewed
Feb 23, 2024
examples/experimental/sling_decorator/sling_decorator/__init__.py
Outdated
Show resolved
Hide resolved
cmpadden
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending use of docker
for psql
.
Might want to consider running duckdb
in the docker container too.
PedramNavid
force-pushed
the
pdrm/sling-example
branch
from
February 23, 2024 22:32
7dd494c
to
0f97c58
Compare
Co-authored-by: colton <[email protected]>
PedramNavid
force-pushed
the
pdrm/sling-example
branch
from
February 23, 2024 22:35
0f97c58
to
81364d1
Compare
This was referenced Feb 25, 2024
PedramNavid
added a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation This adds a basic example for the Sling integration. It includes a few helper make targets to start a seeded Postgres instance using Docker, as well as a sample Sling replication.yaml and asset decorator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This adds a basic example for the Sling integration. It includes a few helper make targets
to start a seeded Postgres instance using Docker, as well as a sample Sling replication.yaml
and asset decorator.
How I Tested These Changes
I ran it