Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[daggy u] Allow dbt/jinja template in code block (DEV-158) #20169

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Feb 29, 2024

Summary & Motivation

Use custom code block rendering to allow rendering the dbt/jinja template code to show up. (Currently it's handled in an undesirable way by markdoc.)

Screenshot 2024-02-29 at 15.52.22.png

Also added some padding on the bottom of main.

How I Tested These Changes

yarn dev

Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@hellendag hellendag marked this pull request as ready for review February 29, 2024 22:04
@erinkcochran87 erinkcochran87 changed the title [daggy u] Allow dbt/jinja template in code block [daggy u] Allow dbt/jinja template in code block (DEV-158) Feb 29, 2024
Copy link
Contributor

@erinkcochran87 erinkcochran87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down and checked out a bunch of different code blocks (include the obfuscated ones) and everything looks ok to me! Thank you so much for this!

@hellendag hellendag force-pushed the dish/dev-158-daggy-u-allow-templating-code-to-be-visible-in-code-blocks branch 6 times, most recently from 517e209 to c2c2570 Compare March 1, 2024 15:40
@hellendag hellendag merged commit 552307a into master Mar 1, 2024
0 of 2 checks passed
@hellendag hellendag deleted the dish/dev-158-daggy-u-allow-templating-code-to-be-visible-in-code-blocks branch March 1, 2024 16:01
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
## Summary & Motivation

Use custom code block rendering to allow rendering the dbt/jinja
template code to show up. (Currently it's handled in an undesirable way
by markdoc.)

![Screenshot 2024-02-29 at
15.52.22.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/04l624FRNbtX4kJhQyXR/046a6b6b-3218-48b9-ada9-cb64f8b0485d.png)

Also added some padding on the bottom of `main`.

## How I Tested These Changes

yarn dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants