[external-assets] asset checks dup check #20361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2024
smackesey
force-pushed
the
sean/allow-mixed-asset-jobs
branch
from
06e3dba to
4a3c5b2
Compare
smackesey
force-pushed
the
sean/external-assets-asset-checks
branch
from
96c8dd2 to
aca467d
Compare
alangenfeld
approved these changes
Mar 8, 2024
johannkm
approved these changes
Mar 8, 2024
smackesey
force-pushed
the
sean/allow-mixed-asset-jobs
branch
from
4a3c5b2 to
46c50a5
Compare
smackesey
force-pushed
the
sean/external-assets-asset-checks
branch
from
aca467d to
7408446
Compare
smackesey
force-pushed
the
sean/allow-mixed-asset-jobs
branch
from
46c50a5 to
5deee20
Compare
smackesey
force-pushed
the
sean/external-assets-asset-checks
branch
from
7408446 to
f104d31
Compare
smackesey
force-pushed
the
sean/external-assets-asset-checks
branch
from
f104d31 to
1c30a6b
Compare
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation In the status quo, duplicate asset check keys are only caught during asset job construction. This moves the duplicate check to the definitions layer (where we catch dup asset keys). ## How I Tested These Changes Updated existing unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
In the status quo, duplicate asset check keys are only caught during asset job construction. This moves the duplicate check to the definitions layer (where we catch dup asset keys).
How I Tested These Changes
Updated existing unit test.