Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dbt): add parameter toggle to emit column dependency metadata #20548

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

rexledesma
Copy link
Contributor

Summary & Motivation

Allow the collection of column schema metadata for a dbt node's parents to be enabled or disabled. Disabling this collection prevents column dependencies from being emitted in the dbt node's materialization.

How I Tested These Changes

pytest, added docs

@rexledesma rexledesma requested a review from sryza March 18, 2024 21:56
Copy link
Contributor Author

rexledesma commented Mar 18, 2024

@rexledesma rexledesma changed the title feat(dbt): add toggle to emit column dependency metadata feat(dbt): add parameter toggle to emit column dependency metadata Mar 18, 2024
@rexledesma rexledesma force-pushed the rl/column-lineage-metadata branch from c33f5da to 579cb49 Compare March 18, 2024 22:07
@rexledesma rexledesma force-pushed the rl/make-column-dependencies-optional branch from 8c51d54 to d035115 Compare March 18, 2024 22:07
@@ -570,6 +570,22 @@ snapshots:
- "{{ dagster.log_column_level_metadata() }}"
```

Column dependencies can be removed from materialization metadata by disabling the collection of parent relation metadata. This can be done by setting the `enable_parent_relation_metadata_collection` argument to `False` in the `dagster.log_column_level_metadata()` macro:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore if you feel otherwise, but collect_parent_relation_metadata is shorter and might be equally clear.

@rexledesma rexledesma force-pushed the rl/column-lineage-metadata branch from 579cb49 to a953dac Compare March 19, 2024 19:43
@rexledesma rexledesma force-pushed the rl/make-column-dependencies-optional branch from d035115 to e8d6efb Compare March 19, 2024 19:44
@rexledesma rexledesma force-pushed the rl/column-lineage-metadata branch from a953dac to 11709ae Compare March 19, 2024 20:45
@rexledesma rexledesma force-pushed the rl/make-column-dependencies-optional branch from e8d6efb to de86c55 Compare March 19, 2024 20:45
@rexledesma rexledesma force-pushed the rl/column-lineage-metadata branch from 11709ae to 4f0105d Compare March 20, 2024 15:54
@rexledesma rexledesma force-pushed the rl/make-column-dependencies-optional branch from de86c55 to 926c496 Compare March 20, 2024 15:54
@rexledesma rexledesma force-pushed the rl/column-lineage-metadata branch from 4f0105d to 0456137 Compare March 20, 2024 17:54
@rexledesma rexledesma force-pushed the rl/make-column-dependencies-optional branch from 926c496 to a683924 Compare March 20, 2024 17:54
Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-j0xs3c459-elementl.vercel.app
https://rl-make-column-dependencies-optional.core-storybook.dagster-docs.io

Built with commit a683924.
This pull request is being automatically deployed with vercel-action

@rexledesma rexledesma force-pushed the rl/column-lineage-metadata branch from 0456137 to ba083cc Compare March 20, 2024 22:13
@rexledesma rexledesma force-pushed the rl/make-column-dependencies-optional branch from a683924 to 566fe88 Compare March 20, 2024 22:13
@rexledesma rexledesma force-pushed the rl/column-lineage-metadata branch from ba083cc to 0628a9c Compare March 20, 2024 22:39
@rexledesma rexledesma force-pushed the rl/make-column-dependencies-optional branch from 566fe88 to c05e69a Compare March 20, 2024 22:39
Copy link
Contributor Author

rexledesma commented Mar 20, 2024

Merge activity

  • Mar 20, 4:11 PM PDT: @rexledesma started a stack merge that includes this pull request via Graphite.
  • Mar 20, 4:12 PM PDT: Graphite rebased this pull request as part of a merge.
  • Mar 20, 4:13 PM PDT: @rexledesma merged this pull request with Graphite.

Base automatically changed from rl/column-lineage-metadata to master March 20, 2024 23:11
@rexledesma rexledesma force-pushed the rl/make-column-dependencies-optional branch from c05e69a to 0024112 Compare March 20, 2024 23:11
@rexledesma rexledesma merged commit a31f7ff into master Mar 20, 2024
1 of 2 checks passed
@rexledesma rexledesma deleted the rl/make-column-dependencies-optional branch March 20, 2024 23:13
benpankow pushed a commit that referenced this pull request Mar 21, 2024
…20548)

## Summary & Motivation
Allow the collection of column schema metadata for a dbt node's parents to be enabled or disabled. Disabling this collection prevents column dependencies from being emitted in the dbt node's materialization.

## How I Tested These Changes
pytest, added docs
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
…20548)

## Summary & Motivation
Allow the collection of column schema metadata for a dbt node's parents to be enabled or disabled. Disabling this collection prevents column dependencies from being emitted in the dbt node's materialization.

## How I Tested These Changes
pytest, added docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants