Add injected component for cloud to modify user preferences #20671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit c2605e8. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit c2605e8. |
bengotow
approved these changes
Mar 25, 2024
| @@ -0,0 +1,3 @@ | |||
| import {componentStub} from '../InjectedComponentContext'; | |||
|
|
|||
| export const UserPreferences = componentStub('UserPreferences'); | |||
salazarm
deleted the
salazarm/add-injected-component-for-cloud-user-preferences
branch
PedramNavid
pushed a commit
that referenced
this pull request
Mar 28, 2024
## Summary & Motivation As titled. Note I included the RoundedButton change in this PR so I don't have to open another one... it's from https://github.com/dagster-io/internal/blob/master/dagster-cloud/js_modules/app-cloud/src/deployment-switcher/DeploymentSwitcher.tsx#L306 I'm going to reuse that button style for the catalog mode button OSS PR: dagster-io/internal#8882 ## How I Tested These Changes Locally made sure that settings still load and that we reload when settings change 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As titled.
Note I included the RoundedButton change in this PR so I don't have to open another one... it's from https://github.com/dagster-io/internal/blob/master/dagster-cloud/js_modules/app-cloud/src/deployment-switcher/DeploymentSwitcher.tsx#L306
I'm going to reuse that button style for the catalog mode button
OSS PR: https://github.com/dagster-io/internal/pull/8882
How I Tested These Changes
Locally made sure that settings still load and that we reload when settings change